From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=maxchernoff.ca
Authentication-Results: passt.top;
	dkim=pass (2048-bit key; secure) header.d=maxchernoff.ca header.i=@maxchernoff.ca header.a=rsa-sha256 header.s=key1 header.b=pj1xZTrp;
	dkim-atps=neutral
Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [IPv6:2001:41d0:203:375::b0])
	by passt.top (Postfix) with ESMTPS id 5EB7F5A0271
	for <passt-dev@passt.top>; Mon, 08 Dec 2025 09:17:07 +0100 (CET)
Message-ID: <0322d7460b05a0e5e08acdd9e4d4c21950b7825f.camel@maxchernoff.ca>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maxchernoff.ca;
	s=key1; t=1765181826;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cVH2GA3J+kWTj6e4il8Ld9zXMWtNK0I8favPo6L5ZFY=;
	b=pj1xZTrp3JJArlxttzCAjp24ncMjbMdeYTfHHO0oeUmTJzzNyMHmzFWV5i5NCjN27v8u9a
	CxBAFEatv5Y5hTh2ffmyGR5TkxLlk/BMVGBuE8nDv5/6Tk6jQs/1pY3wGsSPHhmKDbMT5H
	Q768Lbi1hn5ugnxnnc2NrpxWNAcIjirvqlt8ZiNhHDNk3Pk3/yObvh6z4NSxIlY12XX2dA
	xLMPyNL8siJR1L+S/JBcTosqOQlOpCc5dT9jGVg4hd9IH7aTiaTsTVgJNwYrH7zCRJWRQM
	hx6aBbL6Eot7hxA4BgLrAFPXCAfN+8tU0K1MqFKj/VrS8xbsNXwtC32TB87xxw==
Subject: Re: [PATCH v3 08/10] tcp: Allow exceeding the available sending
 buffer size in window advertisements
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Max Chernoff <git@maxchernoff.ca>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
In-Reply-To: <20251208072024.3884137-9-sbrivio@redhat.com>
References: <20251208072024.3884137-1-sbrivio@redhat.com>
	 <20251208072024.3884137-9-sbrivio@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Date: Mon, 08 Dec 2025 01:14:01 -0700
MIME-Version: 1.0
X-Migadu-Flow: FLOW_OUT
Message-ID-Hash: LRDY6C6CYEPE5KWKM4BPRP3G4JNOBRU5
X-Message-ID-Hash: LRDY6C6CYEPE5KWKM4BPRP3G4JNOBRU5
X-MailFrom: git@maxchernoff.ca
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: David Gibson <david@gibson.dropbear.id.au>
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/0322d7460b05a0e5e08acdd9e4d4c21950b7825f.camel@maxchernoff.ca/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/LRDY6C6CYEPE5KWKM4BPRP3G4JNOBRU5/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>

Hi Stefano,

On Mon, 2025-12-08 at 08:20 +0100, Stefano Brivio wrote:
> @@ -1035,6 +1042,35 @@ void tcp_fill_headers(const struct ctx *c, struct =
tcp_tap_conn *conn,
>  	tap_hdr_update(taph, MAX(l3len + sizeof(struct ethhdr), ETH_ZLEN));
>  }

This chunk fails to apply because master currently has the following
line instead:

    tap_hdr_update(taph, l3len + sizeof(struct ethhdr));

The patch applied cleanly after I fixed the context though.

Thanks,
-- Max