From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=a9F+6Vre; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 972975A0265 for ; Mon, 04 May 2026 11:12:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777885943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=erWofiRJ8lLxXOx1/o7OtNjTnOX2oYcjin8zsoU8YUM=; b=a9F+6Vreh+h6VGjC3InI/PzwUBQJz+GMMmVvCZ26iVDfWxOJQ5OvdxZZB2VJL1GTghco3f hJjfTwgiamPVVHF7He+AxgqDcNSgI4nNjWI8pUY0/oUgHw+F3Ao5FHl+jYFppo/50+ZjJj n3oqMjMUhHGMcAckt3Xqr+Vvf/NRRQ0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-X5AdJl32NYmuDBsiPaYt7g-1; Mon, 04 May 2026 05:12:22 -0400 X-MC-Unique: X5AdJl32NYmuDBsiPaYt7g-1 X-Mimecast-MFC-AGG-ID: X5AdJl32NYmuDBsiPaYt7g_1777885941 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-441243ba35fso3537740f8f.0 for ; Mon, 04 May 2026 02:12:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777885941; x=1778490741; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=erWofiRJ8lLxXOx1/o7OtNjTnOX2oYcjin8zsoU8YUM=; b=bpOyI/OWIYGp9nsg7ZgS0cZS2mgPM2P4g1s99K/D9Mq9+MYVe+z5CnJBycP1lHmWLu PSOe2YGtZ15/5VRDNJCw8gv5Wi1FXta9NsqBS72Mb8bkXce/ROoV0ljhp8xb+yjwR/Rv NaHG9cYtXBFqAnEQYMRHyfmqGuj1aC1AuwXTQNT1o3ohM4wwAZiIlqbc0pOApT9aLU5x ++EzbYZx3Zjnmv+lRWU6ksoCmI8YE3PhRwbjAnWxiWbYP2C1uF3yWC7casMVPwLkCdGk grOF3QuAeC7CpFYsJGFyE+6mgwkw8dJMP1iDoCTYHT72092/NO62CAK85ept266UYs9Z 4g/Q== X-Forwarded-Encrypted: i=1; AFNElJ+VJU9Hog2nJibRiANhUtDY0fqlg0gyqySNrNBxp7i2UXHxTHUmW8Ss+jqDcG+zPPAb1DC4cX533Jw=@passt.top X-Gm-Message-State: AOJu0Yy2+cmgT/ZffU8yOi8kAqXib8FnVAzKy6hiA5fC1H6ZZuLZ+G1M 6EGAK1fEi3zB7Cs/c+suu4qokN60R5XUxjUPJoqKkpSGBjGcR4sQWTffI0nqj6DM50+wS7YRlmi E9LxVQAQl6uXplmcu4g+Hgna2tkYWlNcFVMVjDbtvSYNNRwefYtEPLA== X-Gm-Gg: AeBDietS4rEjVp1FJhSAO+aFyv0saecIa3ynHvBUfVzMPt83j3pBp+ISNMlUMXgHhJY 4J22pbPCmPIn0svW0oQybQZO1b4b3w4nxGrGYShsXoKYQr0TYjwH5HfiBN7DLIBIIHIF6suJvUN cZmmX55XrIr55SLY/vj2mrRSfWhON28PjD+tWDYs0ikz6oETJk6/Qkny6hPY2QK4vvxwvYUfpww ZdD3rDUm+ik7GzCegvzXD8zJc/2EXR/wbwT/1ob9596uycpCo4hEDTjQTyeCxrIwldVvfqjYx3Z 4x4nOnOZGbKogJFpRs9e8YL7PK48suCdQepfNs71lEnA65I/YV59sZOa7q+lPlWUONpdpThNfgc jz8p6hXfLpdFf62XByIYuQTclZlp17JLP0+nO X-Received: by 2002:a05:600c:698d:b0:489:ad:7b5b with SMTP id 5b1f17b1804b1-48a9866e8a5mr143441375e9.24.1777885941007; Mon, 04 May 2026 02:12:21 -0700 (PDT) X-Received: by 2002:a05:600c:698d:b0:489:ad:7b5b with SMTP id 5b1f17b1804b1-48a9866e8a5mr143440315e9.24.1777885940230; Mon, 04 May 2026 02:12:20 -0700 (PDT) Received: from [192.168.100.100] ([82.64.211.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8ff04927sm88743385e9.36.2026.05.04.02.12.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 02:12:19 -0700 (PDT) Message-ID: <0834495e-1818-406a-8737-c8e48a4cea6d@redhat.com> Date: Mon, 4 May 2026 11:12:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 06/18] pif: Limit pif names to 128 bytes To: Stefano Brivio , passt-dev@passt.top References: <20260503215601.823029-1-sbrivio@redhat.com> <20260503215601.823029-7-sbrivio@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260503215601.823029-7-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IFKKzkABf-vKO_JX7gxLIJ1LuAnQcx1f0rAhcuPX7Tw_1777885941 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: D7CJLQNCME3FWYLFLM2VYWK5ZWRUY372 X-Message-ID-Hash: D7CJLQNCME3FWYLFLM2VYWK5ZWRUY372 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jon Maloy , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/3/26 23:55, Stefano Brivio wrote: > From: David Gibson > > All current pif names are quite short, and we expect them to remain short > when/if we allow arbitrary pifs. However, because of the structure of > the current code we don't enforce any limit on the length. > > This will become more important with dynamic configuration updates, so > start enforcing a length limit. Specifically we allow pif names to be up > to 128 bytes (PIF_NAME_SIZE), including the terminating \0. This is > more or less arbitrary, but seems like it should be comfortably enough for > all the cases we have in mind. > > Signed-off-by: David Gibson > Signed-off-by: Stefano Brivio Reviewed-by: Laurent Vivier There is a little typo below > --- > pif.c | 2 +- > pif.h | 5 ++++- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/pif.c b/pif.c > index 1e80724..d5e3161 100644 > --- a/pif.c > +++ b/pif.c > @@ -17,7 +17,7 @@ > #include "inany.h" > #include "epoll_ctl.h" > > -const char *pif_type_str[] = { > +const char pif_type_str[][PIF_NAME_SIZE] = { > [PIF_NONE] = "", > [PIF_HOST] = "HOST", > [PIF_TAP] = "TAP", > diff --git a/pif.h b/pif.h > index 7bb58e5..90dd3a3 100644 > --- a/pif.h > +++ b/pif.h > @@ -35,7 +35,9 @@ enum pif_type { > PIF_NUM_TYPES, > }; > > -extern const char *pif_type_str[]; > +/* Maxmimum size of a pif name, including \0 */ "Maximum" > +#define PIF_NAME_SIZE (128) > +extern const char pif_type_str[][PIF_NAME_SIZE]; > > static inline const char *pif_type(enum pif_type pt) > { > @@ -43,6 +45,7 @@ static inline const char *pif_type(enum pif_type pt) > return pif_type_str[pt]; > else > return "?"; > + static_assert(sizeof("?") <= PIF_NAME_SIZE); > } > > static inline const char *pif_name(uint8_t pif)