From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OzeQbryj; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 916FA5A026E for ; Mon, 20 Apr 2026 18:11:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776701482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=anbyGzDU9lJxz1g/r9WH5nXg0G+HksuPcJxQCRuajVY=; b=OzeQbryj1z3p5PzCacD9iWmVjooYFuqB5kVQWZOmSKGrJpsFayGic/tseVCE+BM9CVqCEi vVhpwT8Z0/8mYaSWz7LrC/+zQYFo80SaFqUhcDYdL9EGgpCHErja++vHvzRWqkNDtgn7b+ B0058Dai7o+SnQ720lcEj9vxa44xpe0= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-jaNy6FmfOH2KlSh1UGf_4A-1; Mon, 20 Apr 2026 12:11:21 -0400 X-MC-Unique: jaNy6FmfOH2KlSh1UGf_4A-1 X-Mimecast-MFC-AGG-ID: jaNy6FmfOH2KlSh1UGf_4A_1776701480 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b2ead99f5dso40889575ad.0 for ; Mon, 20 Apr 2026 09:11:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776701480; x=1777306280; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=anbyGzDU9lJxz1g/r9WH5nXg0G+HksuPcJxQCRuajVY=; b=h7ptLjZ780rtAok5YexPx9tI4WpZXgsCLWm+R+fE1qccGOELxsbJr3pBKclKTDQSNB prqWqMBA0K5ORgORlxduVpv9E+3D3wIZAGdZ6mEoBXQnWh+RU0jd9+MB+09VgkMT/Uqf FkW1gaN9DI4dU/QHc0NgLldOpMO8g/T1laYbUxoA2InAgQnhtwZgz4Eptp1UVIcK4l5s NGtihCxlq9MurdJPgWgocKwm0l3YdmmXGP6bDfND7VZMoVmX/us565h1U6bnRas5HETh zwXlojAuGxQe5zR8PuJDkuJPRcFMpfupKEnthiBoEQaoKVN4cTtTJt+jxsZ+XCKy427c RwQw== X-Forwarded-Encrypted: i=1; AFNElJ+cYw1JhVkQAttCtq0Y8bc9iBbKNAjM/oCRLibEyTUFNNFWf/GVe7xRAe0i5wyk/q0InqNkdrqE5dY=@passt.top X-Gm-Message-State: AOJu0YzB9i/CBm07l7L1bbXD8lh5osVFNk1zFj+3wc273Z+Oba4Nd0A2 1PrjMySY8VvpKfNOxSpWIO32Pfo2Sthu26dir8kqE/TDN1dxOOBuWLTimBHniLa6h/zUQOQoANx UNZY2X8vFT7JHYXjphKIRmtXOtP5ct3QAM3Od5GGeIiEQJcMbG0A/UBJqx8FV5A== X-Gm-Gg: AeBDieuRfs34CVxaqmIt+dx3LCx83v6Yw/EdfeXavg/DF9KdrXYS564P8PV/wER0pT8 jwYWV/9pT+B4XnWJckfmDoY88hMVNOPtl1aWlT12pQgGO8cHJmo0gHlqimYTM+zlEdhkFvf1S4F c9j+AaZh5l4QHczqw6mkHWopEEqY9lQX8DPgjRpG8bIxC4C7eNFMoJpyMIoUIGQiyr4cuy5WC37 TufT4+ZdAzC8St00UudQSnoUVZ70kH48v5gTzbJa9kSuvNgoQZSGGD8bc2IFXCOi4vM/Y1jcCsn sq620ekkeuYVi3kc2xYuuimnBbhCTow6Sa4NPSwX1uF/X49+5Si9i7HNEzgzoWVV23kqjFFUqwB omjdppGuRc5e9ADw370SSdmFAopOIBuMzNU54mPJWK0RrrVBEAya84Ekom4hjGCu0cw== X-Received: by 2002:a17:903:28e:b0:2b0:7531:b61e with SMTP id d9443c01a7336-2b5f9f9f125mr145189295ad.41.1776701479771; Mon, 20 Apr 2026 09:11:19 -0700 (PDT) X-Received: by 2002:a17:903:28e:b0:2b0:7531:b61e with SMTP id d9443c01a7336-2b5f9f9f125mr145189055ad.41.1776701479306; Mon, 20 Apr 2026 09:11:19 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab2114bsm104273025ad.60.2026.04.20.09.11.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 09:11:18 -0700 (PDT) Message-ID: <09fae4b1-415c-4200-8beb-c0975f8891f4@redhat.com> Date: Mon, 20 Apr 2026 18:11:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/11] conf: Don't pass raw commandline argument to conf_ports_spec() To: David Gibson , passt-dev@passt.top, Stefano Brivio References: <20260417050520.102247-1-david@gibson.dropbear.id.au> <20260417050520.102247-6-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260417050520.102247-6-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ON7gzbDJa4mR1TPHZOgtLfC68EhDCfbRWnRZiAKpmgw_1776701480 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: ZI2FWXXV4ROLGV32LR55ZX4GXL4LBQX4 X-Message-ID-Hash: ZI2FWXXV4ROLGV32LR55ZX4GXL4LBQX4 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/17/26 07:05, David Gibson wrote: > We only use the optname and optarg parameters for printing error messages, > and they're not even particularly necessary there. Remove them. > > Signed-off-by: David Gibson Reviewed-by: Laurent Vivier > --- > conf.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/conf.c b/conf.c > index 5ff62873..99542075 100644 > --- a/conf.c > +++ b/conf.c > @@ -219,8 +219,6 @@ fail: > /** > * conf_ports_spec() - Parse port range(s) specifier > * @c: Execution context > - * @optname: Short option name, t, T, u, or U > - * @optarg: Option argument (port specification) > * @fwd: Forwarding table to be updated > * @proto: Protocol to forward > * @addr: Listening address for forwarding > @@ -228,7 +226,6 @@ fail: > * @spec: Port range(s) specifier > */ > static void conf_ports_spec(const struct ctx *c, > - char optname, const char *optarg, > struct fwd_table *fwd, uint8_t proto, > const union inany_addr *addr, const char *ifname, > const char *spec) > @@ -316,8 +313,7 @@ static void conf_ports_spec(const struct ctx *c, > goto bad; > > if (orig_range.first == 0) { > - die("Can't forward port 0 for option '-%c %s'", > - optname, optarg); > + die("Can't forward port 0 included in '%s'", spec); > } > > conf_ports_range_except(fwd, proto, addr, ifname, > @@ -328,7 +324,7 @@ static void conf_ports_spec(const struct ctx *c, > > return; > bad: > - die("Invalid port specifier %s", optarg); > + die("Invalid port specifier '%s'", spec); > } > > /** > @@ -432,11 +428,11 @@ static void conf_ports(const struct ctx *c, char optname, const char *optarg, > optname, optarg); > > if (c->ifi4) { > - conf_ports_spec(c, optname, optarg, fwd, proto, > + conf_ports_spec(c, fwd, proto, > &inany_loopback4, NULL, spec); > } > if (c->ifi6) { > - conf_ports_spec(c, optname, optarg, fwd, proto, > + conf_ports_spec(c, fwd, proto, > &inany_loopback6, NULL, spec); > } > return; > @@ -451,7 +447,7 @@ static void conf_ports(const struct ctx *c, char optname, const char *optarg, > optname, optarg); > } > > - conf_ports_spec(c, optname, optarg, fwd, proto, addr, ifname, spec); > + conf_ports_spec(c, fwd, proto, addr, ifname, spec); > } > > /**