From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 8D0D95A0082 for ; Mon, 9 Jan 2023 08:04:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673247870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UckizAAQqKtdTE6px4CxxOXN/DH9hT5lq1+ZGXjdWsA=; b=V9StveUVIUiIhlLSmFsUJC4UpFYKDZUrNs32N1rTorIE/fl+f3pij1uEbuGg+K57J1XaOH x6Qe2uiDdNPTjL68dQdZCA0lcxoUVenltvIXIVOCNjr2r7/nZToVDMctGmHIEMM6tiMKkz meuES40Yq1CCNmObqdlUPj6TGCrTKzE= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-580-oEsCU_rFOsSTEfH-Za9THQ-1; Mon, 09 Jan 2023 02:04:21 -0500 X-MC-Unique: oEsCU_rFOsSTEfH-Za9THQ-1 Received: by mail-qt1-f199.google.com with SMTP id a13-20020ac8610d000000b003a8151cadebso3492162qtm.10 for ; Sun, 08 Jan 2023 23:04:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:to :references:cc:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UckizAAQqKtdTE6px4CxxOXN/DH9hT5lq1+ZGXjdWsA=; b=np+IcS3IsB3ubetX6jDM3yn3cCynwIGsLAIIjXyhiJZ9PsXafpMvY/846Z+johMAAp uwY/gZprL9XsV0tW8WuJX+KDBlCwoezmfxKIMw/TQkNFrEb4od3KGDwPDobsC+07efvK 9as/leWSbQoNcXOqlvamsN+UV+fPP7HEZY0PPA+hvOE/HItNAQMVqYi8reXGkvEGsuwG GLlXfjuKNRZ59p1hbmQyf3Ak8Ei+GO9gPkKd4CTYhO2vyE5g5FKIgT40pwEytB7l/qAj JzexEgJzysBqg+fw4fejAtVgfHsQsG2FHaOka7AdQM37Yl2TtsAxQTM0oNimN1jG+Xgj 7Y+Q== X-Gm-Message-State: AFqh2kpuU351kCfmZ1UMIkoIOwjuogfezOtJA4AZi1rav+PCeonL9DfG WbhQEoz3gT8+4Ipfrmj+20ve6n9Nr5bFwKkgEhNVP17kM75y5T3Jy/Eim6nsULU/S18DF4YYLMH IVpyTQHzjypM7 X-Received: by 2002:ac8:5495:0:b0:3a8:3d8:4e68 with SMTP id h21-20020ac85495000000b003a803d84e68mr89040958qtq.55.1673247861043; Sun, 08 Jan 2023 23:04:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXu1w+ziKHhJLvX+USyfUIJ8oMH+18fLfpb2Ivjt0DVjke4jlIoQToG3Qkly8eh8eTxmj1XCwA== X-Received: by 2002:ac8:5495:0:b0:3a8:3d8:4e68 with SMTP id h21-20020ac85495000000b003a803d84e68mr89040945qtq.55.1673247860786; Sun, 08 Jan 2023 23:04:20 -0800 (PST) Received: from ?IPV6:2600:8805:3a00:3:d764:fb52:bfdf:c85c? ([2600:8805:3a00:3:d764:fb52:bfdf:c85c]) by smtp.gmail.com with ESMTPSA id d7-20020ac80607000000b003a7ec97c882sm4211394qth.6.2023.01.08.23.04.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Jan 2023 23:04:20 -0800 (PST) Message-ID: <0c6191d2-8972-b630-d1ae-3ecebcf7922e@redhat.com> Date: Mon, 9 Jan 2023 02:04:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [libvirt PATCH 3/9] conf: put interface parsing/formatting separate functions References: <20230109041112.368790-1-laine@redhat.com> <20230109041112.368790-4-laine@redhat.com> To: Libvirt From: Laine Stump Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 Message-ID-Hash: ZXMPDEY4XSC2CATMZ55E3YL2QBVBQA4I X-Message-ID-Hash: ZXMPDEY4XSC2CATMZ55E3YL2QBVBQA4I X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, passt-dev@passt.top, =?UTF-8?Q?J=c3=a1n_Tomko?= X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: T24gMS85LzIzIDE6NDcgQU0sIErDoW4gVG9ta28gd3JvdGU6DQo+IE9uIGEgU3VuZGF5IGluIDIw MjMsIExhaW5lIFN0dW1wIHdyb3RlOg0KPj4gSW4gcHJlcGFyYXRpb24gZm9yIGFkZGluZyBtb3Jl IHN0dWZmIHRvIDxiYWNrZW5kPi4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBMYWluZSBTdHVtcCA8 bGFpbmVAcmVkaGF0LmNvbT4NCj4+IC0tLQ0KPj4NCj4+IEkgd2FudGVkIHZpckRvbWFpbk5ldEJh Y2tlbmRQYXJzZVhNTCB0byBzaW1wbHkgdGFrZSBhDQo+PiB2aXJEb21haW5OZXRCYWNrZW5kKiwg YnV0IHRoZXJlIGlzIGEgdGVzdCBjYXNlIHNwZWNpZmljYWxseSBjaGVja2luZw0KPj4gdG8gYmUg c3VyZSB0aGF0IGJhY2tlbmQvdmhvc3QgaXNuJ3QgcGFyc2VkIGlmIHRoZSBpbnRlcmZhY2UgaXNu J3QNCj4+IHZpcnRpby4gU2lsZW50bHkgSWdub3Jpbmcrc3RyaXBwaW5nIHRoaXMgZHVyaW5nIHBh cnNlIGlzIGFyZ3VhYmx5IHRoZQ0KPj4gd3JvbmcgdGhpbmcgdG8gZG8gLSBlaXRoZXIgd2Ugc2hv dWxkIGxvZyBhbiBlcnJvciBvbiB2YWxpZGF0aW9uLCBvciB3ZQ0KPj4gc2hvdWxkIGp1c3QgbGVh dmUgaXQgaW4gKGl0J3Mgb25seSBldmVyIHVzZWQgaWYgdGhlIGludGVyZmFjZSBpcw0KPj4gdmly dGlvKSwgYnV0IHRoYXQncyBhIHByb2JsZW0gZm9yIGFub3RoZXIgZGF5Lg0KPj4NCj4+IChPcGlu aW9ucyBvbiB0aGUgcHJvcGVyIHRoaW5nIHRvIGRvIGFyZSB3ZWxjb21lIC0gc2luY2UgaXQncyBj dXJyZW50bHkNCj4+IGFsd2F5cyBzdHJpcHBlZCBvdXQgb24gcGFyc2UsIEkgKnRoaW5rKiBJIGNv dWxkIGJlZ2luIGNoZWNraW5nIGZvciBpdA0KPj4gZHVyaW5nIHZhbGlkYXRpb24gLSB0aGVyZSBp cyBubyB3YXkgdGhhdCBvbGQgY29kZSBjb3VsZCBsZWF2ZSB0aGUNCj4+IGJhY2tlbmQvdmhvc3Qg Zm9yIGEgbm9uLXZpcnRpbyBpbnRlcmZhY2UgaW4gYW55IGRvbWFpbiB4bWwgd3JpdHRlbiB0bw0K Pj4gZGlzay4NCj4gDQo+IFRoaXMgc2VlbXMgbGlrZSB0aGUgcmlnaHQgdGhpbmcgdG8gZG8uDQo+ IA0KPj4gQWx0ZXJuYXRlbHkgd291bGQgY291bGQganVzdCBhbGxvdyBpdCB0byBiZSBwYXJzZWQg YW5kDQo+PiBmYWl0aGZ1bGx5IGZvcm1hdCBpdCBldmVuIHdoZW4gdGhlIGludGVyZmFjZSBpc24n dCB2aXJ0aW8sIGFuZCBub3QgbG9nDQo+PiBhbnkgZXJyb3IuKQ0KPj4NCj4+IHNyYy9jb25mL2Rv bWFpbl9jb25mLmMgfCA1NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0NCj4+IDEgZmlsZSBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkN Cj4+DQo+PiBkaWZmIC0tZ2l0IGEvc3JjL2NvbmYvZG9tYWluX2NvbmYuYyBiL3NyYy9jb25mL2Rv bWFpbl9jb25mLmMNCj4+IGluZGV4IDMwYjBjZWYxMzEuLjk1MDJmMmViYWIgMTAwNjQ0DQo+PiAt LS0gYS9zcmMvY29uZi9kb21haW5fY29uZi5jDQo+PiArKysgYi9zcmMvY29uZi9kb21haW5fY29u Zi5jDQo+PiBAQCAtODk3MCw2ICs4OTcwLDI2IEBAIHZpckRvbWFpbk5ldERlZlBhcnNlWE1MRHJp dmVyKHZpckRvbWFpbk5ldERlZiANCj4+ICpkZWYsDQo+PiB9DQo+Pg0KPj4NCj4+ICtzdGF0aWMg aW50DQo+PiArdmlyRG9tYWluTmV0QmFja2VuZFBhcnNlWE1MKHhtbE5vZGVQdHIgbm9kZSwNCj4+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg dmlyRG9tYWluTmV0RGVmICpkZWYpDQo+PiArew0KPj4gK8KgwqDCoCBnX2F1dG9mcmVlIGNoYXIg KnRhcCA9IHZpclhNTFByb3BTdHJpbmcobm9kZSwgInRhcCIpOw0KPj4gK8KgwqDCoCBnX2F1dG9m cmVlIGNoYXIgKnZob3N0ID0gdmlyWE1MUHJvcFN0cmluZyhub2RlLCAidmhvc3QiKTsNCj4+ICsN Cj4+ICvCoMKgwqAgaWYgKHRhcCkNCj4+ICvCoMKgwqDCoMKgwqDCoCBkZWYtPmJhY2tlbmQudGFw ID0gdmlyRmlsZVNhbml0aXplUGF0aCh0YXApOw0KPj4gKw0KPj4gK8KgwqDCoCBpZiAodmhvc3Qg JiYNCj4+ICvCoMKgwqDCoMKgwqDCoCBkZWYtPnR5cGUgIT0gVklSX0RPTUFJTl9ORVRfVFlQRV9I T1NUREVWICYmDQo+PiArwqDCoMKgwqDCoMKgwqAgdmlyRG9tYWluTmV0SXNWaXJ0aW9Nb2RlbChk ZWYpKSB7DQo+PiArwqDCoMKgwqDCoMKgwqAgZGVmLT5iYWNrZW5kLnZob3N0ID0gdmlyRmlsZVNh bml0aXplUGF0aCh2aG9zdCk7DQo+PiArwqDCoMKgIH0NCj4+ICsNCj4+ICvCoMKgwqAgcmV0dXJu IDA7DQo+PiArfQ0KPj4gKw0KPj4gKw0KPj4gc3RhdGljIGludA0KPj4gdmlyRG9tYWluTmV0RGVm UGFyc2VYTUxSZXF1aXJlU291cmNlKHZpckRvbWFpbk5ldERlZiAqZGVmLA0KPj4gwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHhtbE5vZGVQdHIgc291cmNlX25vZGUpDQo+PiBAQCAtOTAxNiw2ICs5MDM2LDcgQEAg dmlyRG9tYWluTmV0RGVmUGFyc2VYTUwodmlyRG9tYWluWE1MT3B0aW9uICp4bWxvcHQsDQo+PiDC oMKgwqAgeG1sTm9kZVB0ciBtYWNfbm9kZSA9IE5VTEw7DQo+PiDCoMKgwqAgeG1sTm9kZVB0ciB0 YXJnZXRfbm9kZSA9IE5VTEw7DQo+PiDCoMKgwqAgeG1sTm9kZVB0ciBjb2FsZXNjZV9ub2RlID0g TlVMTDsNCj4+ICvCoMKgwqAgeG1sTm9kZVB0ciBiYWNrZW5kX25vZGUgPSBOVUxMOw0KPj4gwqDC oMKgIFZJUl9YUEFUSF9OT0RFX0FVVE9SRVNUT1JFKGN0eHQpDQo+PiDCoMKgwqAgaW50IHJ2Ow0K Pj4gwqDCoMKgIGdfYXV0b2ZyZWUgY2hhciAqbWFjYWRkciA9IE5VTEw7DQo+IA0KPiBzcmMvY29u Zi9kb21haW5fY29uZi5jOjkyMjA6MjI6IGVycm9yOiB1bnVzZWQgdmFyaWFibGUgJ3RhcCcgDQo+ IFstV2Vycm9yLC1XdW51c2VkLXZhcmlhYmxlXQ0KPiAgwqDCoMKgIGdfYXV0b2ZyZWUgY2hhciAq dGFwID0gTlVMTDsNCj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg Xg0KPiAxIGVycm9yIGdlbmVyYXRlZC4NCg0KWWVhaCwgSSBqdXN0IGZvdW5kIHRoYXQgd2hlbiBJ IGxvb2tlZCBhdCB0aGUgcmVzdWx0cyBvZiBnaXRsYWIgQ0kgKGl0IA0KaXNuJ3QgZm91bmQgYnkg Z2NjIGluIEZlZG9yYSAzNyA6LS8pLiBJIGZpeGVkIHRoYXQgYXMgd2VsbCBhcyANCmVsaW1pbmF0 aW5nIGEgbGVhayBpbiB0aGUgbmV3IGZ1bmN0aW9uIHZpckRvbWFpbk5ldFBvcnRGb3J3YXJkRnJl ZSgpIChJIA0KaGFkIGZvcmdvdHRlbiB0byBmcmVlIHRoZSBwZi0+cmFuZ2UgYWZ0ZXIgZnJlZWlu ZyBhbGwgdGhlIHJhbmdlcyB0aGF0IGl0IA0KcG9pbnRlZCB0bykuDQoNCj4gDQo+PiBAQCAtOTMx OSw5ICs5MzQwLDYgQEAgdmlyRG9tYWluTmV0RGVmUGFyc2VYTUwodmlyRG9tYWluWE1MT3B0aW9u ICp4bWxvcHQsDQo+PiDCoMKgwqDCoMKgwqDCoCAodmlyTmV0RGV2VmxhblBhcnNlKHZsYW5fbm9k ZSwgY3R4dCwgJmRlZi0+dmxhbikgPCAwKSkNCj4+IMKgwqDCoMKgwqDCoMKgIHJldHVybiBOVUxM Ow0KPj4NCj4+IC3CoMKgwqAgaWYgKCh0YXAgPSB2aXJYUGF0aFN0cmluZygic3RyaW5nKC4vYmFj a2VuZC9AdGFwKSIsIGN0eHQpKSkNCj4+IC3CoMKgwqDCoMKgwqDCoCBkZWYtPmJhY2tlbmQudGFw ID0gdmlyRmlsZVNhbml0aXplUGF0aCh0YXApOw0KPj4gLQ0KPj4gwqDCoMKgIGlmICgobWFjX25v ZGUgPSB2aXJYUGF0aE5vZGUoIi4vbWFjIiwgY3R4dCkpKSB7DQo+PiDCoMKgwqDCoMKgwqDCoCBp ZiAoKG1hY2FkZHIgPSB2aXJYTUxQcm9wU3RyaW5nKG1hY19ub2RlLCAiYWRkcmVzcyIpKSkgew0K Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAodmlyTWFjQWRkclBhcnNlKChjb25zdCBjaGFy ICopbWFjYWRkciwgJmRlZi0+bWFjKSA8IDApIHsNCj4gDQo+IFdpdGggdGhlIHVudXNlZCB2YXJp YWJsZSByZW1vdmVkOg0KPiANCj4gUmV2aWV3ZWQtYnk6IErDoW4gVG9ta28gPGp0b21rb0ByZWRo YXQuY29tPg0KPiANCj4gSmFubw0KDQo=