From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CNLRWFmM; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 778DB5A0269 for ; Mon, 11 May 2026 15:21:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778505712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UrheQ4lIut3zuUjCCrncx7y4cIrZpVYb39o8j2iZHDg=; b=CNLRWFmMMZLJA2Zhtwe6C7IhHro7iEboSAyViHrFmBBks/PkD9f5O2wX1P3h4bBZBKRvAk pFSI8lFXG4RgbCH3DD+zfO+ZZ8t0MzRgBhEK2DbwH9DD72WJItj3wkZdDLj2Qdu+0Y2R9V dikmlPIp5ijs7doIniE9U0zu709oaMk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-KVTR_cXwOt2gFufcqAfMxg-1; Mon, 11 May 2026 09:21:51 -0400 X-MC-Unique: KVTR_cXwOt2gFufcqAfMxg-1 X-Mimecast-MFC-AGG-ID: KVTR_cXwOt2gFufcqAfMxg_1778505710 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48a55de6fb0so29831665e9.3 for ; Mon, 11 May 2026 06:21:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778505710; x=1779110510; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UrheQ4lIut3zuUjCCrncx7y4cIrZpVYb39o8j2iZHDg=; b=UPsd+wqqCM0SQ6oYic21Mb1veWv6DmeIVQ39NnG0R6RwMDwRevXjis94gezD8iJM3b 1oOBqVnvLefwqoqitzsEoNYPVn+x/tEArjZ3AD8kAgsl4LOBFtE2v6vUfQSoHqwWAUwx Pm9rttSuDvlQl8SIOJX+G36PxGskITiaMo5tCTwCBro1b5TBHaCxHyrciZScabkQNLzS 3VDxXt2rbUDqDtXSulIYGU1ncM2JDVyohasHkdktSQzBY72nvJWVvw10ax/kJhvpLKPC oNe3/jJunDLOHdMRYj1qJgdow9lX3Se9KeS1xt1AVSHpkNQhu0qhaeLui8mG2c6qjcxS slZg== X-Forwarded-Encrypted: i=1; AFNElJ/7AWLU3VoLxEa3gc3MfGD+EcycDCUY2+gyNCTVz8mBJmWtEpic/3RP67VztYZs03jZ3UAe/NFI6R8=@passt.top X-Gm-Message-State: AOJu0Yxw1qdj4+d2F47TaIn0TdeIpBgfiJFvNtKFuSNeP6PkSqFwLwAm KwndBLW/SraNEaaC4HRT56BDG45usVbA2qmB+3tJyYBS/kri1/MQO+PUgfAPPFJktTehZhQE7sh ieMNYizIGiFAJIGuvetK4+8QDl0qGgS7JMEjCYY0HkPZJsgTRfJB1mVM7g1a37g== X-Gm-Gg: Acq92OE4aqzmVCbe7gOUndcpP/qtOd0EJQEHoXpVj1d5Jnn5/l98j2i7VcIhqL8Zprc mXw7zg+ut2XRJtfip9OUwgy06NME/jDTgkn5yvl46BfDSG6uU8g/d9vdpvjd7QCkSkoQp11Xb3k Sh7PzFrXF1VvDKcK3SnqIyF7lruC8fWqbICzRiTzTW0iJSIsEw+sZjjHmR1QDAl1YCAb4gaej54 hOpVKlpKqw0QuoyTCROdD77hvPL/Gx7QplFr7TfLFWwzDOAZuVXdo2R/7L5sCyO/5rGxaTJs9FA k0PKISdN0xZ8kAQepMQvfWDHruRSRqauL0M+NlIe38HKnoLEokTA8a8XVWOB1r8K11GIaoLJ7N8 rufscoDkz+WHMyEbLogaOPvaFhZuUeOPfsoR9BSn/j6f7+l8pqcr51r0= X-Received: by 2002:a05:600c:a30d:b0:48e:6db3:ff3a with SMTP id 5b1f17b1804b1-48e6db3ffdfmr117423885e9.16.1778505708624; Mon, 11 May 2026 06:21:48 -0700 (PDT) X-Received: by 2002:a05:600c:a30d:b0:48e:6db3:ff3a with SMTP id 5b1f17b1804b1-48e6db3ffdfmr117423315e9.16.1778505707892; Mon, 11 May 2026 06:21:47 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6fffba52sm212860125e9.3.2026.05.11.06.21.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 06:21:47 -0700 (PDT) Message-ID: <0cea9362-8f12-4e1c-87da-7f2368c4bcdc@redhat.com> Date: Mon, 11 May 2026 15:21:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] clang-tidy: Squash inconsistent brace warnings in foreach macros To: David Gibson , passt-dev@passt.top, Stefano Brivio References: <20260511100322.1016757-1-david@gibson.dropbear.id.au> <20260511100322.1016757-5-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260511100322.1016757-5-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UIJpQk-3fww8a2PpSZwJIlI-_QJFzSW5z7zigyWKCBY_1778505710 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: U6RLL66G5JSOMWDN42EEHMBAFUFUTM2K X-Message-ID-Hash: U6RLL66G5JSOMWDN42EEHMBAFUFUTM2K X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/11/26 12:03, David Gibson wrote: > clang-tidy, at least as of 22.1.4 complains about if/else statements with > inconsistent braces. We generally do want consistend bracing per our > coding style. However, some of our foreach macros generate inconsistent > bracing in a way that can't really be avoided. Add suppressions to stop > clang-tidy complaining about these. > > Signed-off-by: David Gibson Reviewed-by: Laurent Vivier > --- > flow.c | 2 ++ > flow_table.h | 8 ++++++-- > netlink.c | 1 + > 3 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/flow.c b/flow.c > index 91f2b81f..565ed2b2 100644 > --- a/flow.c > +++ b/flow.c > @@ -67,9 +67,11 @@ static_assert(ARRAY_SIZE(flow_epoll) == FLOW_NUM_TYPES, > > #define foreach_established_tcp_flow(flow) \ > flow_foreach_of_type((flow), FLOW_TCP) \ > + /* NOLINTNEXTLINE(readability-inconsistent-ifelse-braces) */\ > if (!tcp_flow_is_established(&(flow)->tcp)) \ > /* NOLINTNEXTLINE(bugprone-branch-clone) */ \ > continue; \ > + /* NOLINTNEXTLINE(readability-inconsistent-ifelse-braces) */\ > else > > /* Global Flow Table */ > diff --git a/flow_table.h b/flow_table.h > index 7694e726..e4ff6f73 100644 > --- a/flow_table.h > +++ b/flow_table.h > @@ -67,8 +67,10 @@ extern union flow flowtab[]; > */ > #define flow_foreach(flow) \ > flow_foreach_slot((flow)) \ > + /* NOLINTNEXTLINE(readability-inconsistent-ifelse-braces) */\ > if ((flow)->f.state == FLOW_STATE_FREE) \ > (flow) += (flow)->free.n - 1; \ > + /* NOLINTNEXTLINE(readability-inconsistent-ifelse-braces) */\ > else if ((flow)->f.state != FLOW_STATE_ACTIVE) { \ > flow_err((flow), "Bad flow state during traversal"); \ > continue; \ > @@ -81,10 +83,12 @@ extern union flow flowtab[]; > */ > #define flow_foreach_of_type(flow, type_) \ > flow_foreach((flow)) \ > - if ((flow)->f.type != (type_)) \ > + /* NOLINTNEXTLINE(readability-inconsistent-ifelse-braces) */\ > + if ((flow)->f.type != (type_)) \ > /* NOLINTNEXTLINE(bugprone-branch-clone) */ \ > continue; \ > - else > + /* NOLINTNEXTLINE(readability-inconsistent-ifelse-braces) */\ > + else \ > > > /** flow_idx() - Index of flow from common structure > diff --git a/netlink.c b/netlink.c > index 9076462b..c3c830e1 100644 > --- a/netlink.c > +++ b/netlink.c > @@ -224,6 +224,7 @@ static struct nlmsghdr *nl_next(int s, char *buf, struct nlmsghdr *nh, ssize_t * > nl_foreach((nh), (status), (s), (buf), (seq)) \ > if ((nh)->nlmsg_type != (type)) { \ > warn("netlink: Unexpected message type"); \ > + /* NOLINTNEXTLINE(readability-inconsistent-ifelse-braces) */\ > } else > > /**