From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DVt5a6Vg; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id EB36F5A0262 for ; Thu, 12 Mar 2026 11:42:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773312155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=J1NK735LL7hypbGyYPG3RhtSx/tcsu1dBErupWBo+KY=; b=DVt5a6VgXe8s3wTovoae+mj3+0vs1qgrCej4EJtGF4+OBqeaO5Ez/8vPOD83Wi2clFk6El pK/ruDEjlWgQiLpsClMmdng0KoW+0mbrNUmhZBMUTNazhOaoc3XtyedP57jry+aEFCCEQ2 Qk/fpZRnvZ0zLnvVV8K3MGmvmvUGxHU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-qWgd9Z02NPya0HESQ_SlNw-1; Thu, 12 Mar 2026 06:42:34 -0400 X-MC-Unique: qWgd9Z02NPya0HESQ_SlNw-1 X-Mimecast-MFC-AGG-ID: qWgd9Z02NPya0HESQ_SlNw_1773312153 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4852cf0318dso7801955e9.3 for ; Thu, 12 Mar 2026 03:42:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773312153; x=1773916953; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J1NK735LL7hypbGyYPG3RhtSx/tcsu1dBErupWBo+KY=; b=ilzNoRnBdLLTXwd8eEhme8SSPIRpDWAvbosD3W73qHTZoQ+7SKi/rTBiLEgCbcTYnH AepGYdid4Lar3Krejd4fHsSC5oSx8s5rlD4NdzpXiej5U6ebeUjqb1PpyOF1D9qgqWRM 9915i9h/iU0JKCRgY9D/6xWyXBkSerG1DjJ2mfdDCg0eJF8yrz9xhE6NR2gqEb9+Odcj X1tvEaG6aWypB02TPajlDHMs5P7SN+ajBnyzTSsPIe6RGs94fIhxCng/ZBLN0c5B6ovw ctPEOegVygywHBKWJasgmRNaS+YjsSSqowNDElZCVJ7qrnr5JmvkZsTfWn3TIhjPIQJf /P0w== X-Gm-Message-State: AOJu0Yzi6u6DO3C/LUzv3Xvw/TJEAX/IW1T3phpBDI6OeNNTT6LO+I5K qkh2a3ORxy0i2TtmRiVjsqQJ64v/hBI8Qe55OdD8EArxfdOBsND8h1GGqoygJ+pJF6gv7FY8fNU HGrifKzViGlSNprrPzclmmNBNZfgAlahBhJXrB7kIcm44ndQ1prAAig== X-Gm-Gg: ATEYQzy87LeZG6YhzLHsncFyKCXipT9t1+zc66WMYj7EyjGqZGD14rPUu8N6lk4yV3W SEa+rZLjB9ImdDeQgKN/YRwIde6ojlNh06/zOq+k2ugiYeVgi+4CKytzA9fIu0HlfLbFvVg3XsF VVqmXIQDc2e5Sy84bYQvROVnTNW9fatzHujuQfov8uaNNmOGcGTCDgJKEDl6qqPqTTCG4MkG4F3 t/nMwrt8WEIrLKPtNV7/cYgoEu6OMakvE5Y2R4OtaYQzUCtI5V26P49+Zkf9i1QtQILPzda08KP /g4PaDN4X+krSNGMnNs4duFd7SgMybfRvM7D0ohApW2UVkWGnaZXwxo95mAgOni1sfCDu3cwCci qoDoOzjjPdpWttClLcFnoouWsuQyu5KOqiHtydFgtaht0EHr01Vng2gTkC7zl1XuMpQ== X-Received: by 2002:a05:600c:3104:b0:485:3e19:9e01 with SMTP id 5b1f17b1804b1-4854b10d0e1mr94652465e9.28.1773312153137; Thu, 12 Mar 2026 03:42:33 -0700 (PDT) X-Received: by 2002:a05:600c:3104:b0:485:3e19:9e01 with SMTP id 5b1f17b1804b1-4854b10d0e1mr94651975e9.28.1773312152552; Thu, 12 Mar 2026 03:42:32 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4326:a36e:a7cb:624b? ([2a01:e0a:e10:ef90:4326:a36e:a7cb:624b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b0c3aa1sm41407145e9.14.2026.03.12.03.42.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 03:42:31 -0700 (PDT) Message-ID: <0df5955b-949a-46a2-9032-bd1fc7af08c2@redhat.com> Date: Thu, 12 Mar 2026 11:42:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/13] vhost-user,udp: Use 2 iovec entries per element To: David Gibson References: <20260309094744.1907754-1-lvivier@redhat.com> <20260309094744.1907754-14-lvivier@redhat.com> <43363999-76cf-4f4c-a73d-450c5906e6b9@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MPXUH-oy8D8M5D_vnrkiZ3VcUWg_uYb0FTuZ_GhOsu0_1773312153 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: AID3PCFAUMFVC3CVQQGADAQR6P2FGX3Y X-Message-ID-Hash: AID3PCFAUMFVC3CVQQGADAQR6P2FGX3Y X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/12/26 10:47, David Gibson wrote: > On Thu, Mar 12, 2026 at 09:08:33AM +0100, Laurent Vivier wrote: >> On 3/12/26 05:39, David Gibson wrote: >>> On Mon, Mar 09, 2026 at 10:47:44AM +0100, Laurent Vivier wrote: >>>> iPXE places the vnet header in one virtqueue descriptor and the payload >>>> in another. When passt maps these descriptors, it needs two iovecs per >>>> virtqueue element to handle this layout. >>>> >>>> Without this, passt crashes with: >>>> >>>> ASSERTION FAILED in virtqueue_map_desc (virtio.c:403): num_sg < max_num_sg >>>> >>>> Signed-off-by: Laurent Vivier >>>> --- >>>> udp_vu.c | 8 ++++---- >>>> vu_common.c | 15 +++++++++++---- >>>> 2 files changed, 15 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/udp_vu.c b/udp_vu.c >>>> index cb5274aa1d81..47659b0402fd 100644 >>>> --- a/udp_vu.c >>>> +++ b/udp_vu.c >>>> @@ -34,7 +34,7 @@ >>>> #include "vu_common.h" >>>> static struct iovec iov_vu [VIRTQUEUE_MAX_SIZE]; >>>> -static struct vu_virtq_element elem [VIRTQUEUE_MAX_SIZE]; >>>> +static struct vu_virtq_element elem [VIRTQUEUE_MAX_SIZE / IOV_PER_ELEM]; >>> >>> The two level structure of the queues (array of elems, each pointing >>> to an array of iovs) confuses me a bit. I would have thought that >>> VIRTQUEUE_MAX_SIZE represented the maximum number of elements, even if >>> those elements had multiple iovs. Can you enlighten me? >>> >> In all the code until now I supposed the number of iovec is equal to the >> number of element because we had only one iovec per element. >> >> At virtio level, VIRTQUEUE_MAX_SIZE is the number of vring_desc in a >> virtqueue, and a vring_desc is translated to an iovec in >> virtqueue_map_desc() that are collected to an element in >> vu_queue_map_desc(). So in passt, the maximum number of collected iovec will >> be >> VIRTQUEUE_MAX_SIZE and the maximum of element is VIRTQUEUE_MAX_SIZE if we >> have only one iovec per element. > > Ok... sorry, I'm still unclear. Is the "element" a concept that's > part of the "hardware" interface? Or just part of the structure on > the software side? It's a structure on the software side to reflect that a virtqueue entry can be split in several descriptors (addr, size) on the hardware side. A hardware side entry is mapped to a software side element, a hardware side descriptor is mapped to a software side iovec. Thanks, Laurent