Re: [PATCH v8 8/8] test: Add tests for passt in vhost-user mode

[Laurent Vivier <lvivier@redhat.com>]

On 15/10/2024 21:54, Stefano Brivio wrote:
> On Thu, 10 Oct 2024 14:29:02 +0200
> Laurent Vivier <lvivier@redhat.com> wrote:
> 
>> From: Stefano Brivio <sbrivio@redhat.com>
>>
>> Run functional and performance tests for vhost-user mode as well. For
>> functional tests, we add passt_vu and passt_vu_in_ns as symbolic links
>> to their non-vhost-user counterparts, as no differences are intended
>> but we want to distinguish them in test logs.
>>
>> [...]
>>
>> diff --git a/test/two_guests_vu b/test/two_guests_vu
>> new file mode 120000
>> index 000000000000..144b7cac5438
>> --- /dev/null
>> +++ b/test/two_guests_vu
>> @@ -0,0 +1 @@
>> +test/two_guests
>> \ No newline at end of file
> 
> Oops, this link is wrong: it works if you execute the tests from the
> top git directory, but not if you run them from test/. It should simply
> point to 'two_guests', not to 'test/two_guests'.
> 
> For some reason, even with that fixed, v8 fails for me on that test:
> 'dhclient -6 eth0' gets stuck in guest #2 (it works in guest #1). I
> still need to debug that. I'm fairly sure that v6 or v7 worked.
> 

Perhaps because of this:

diff --git a/test/lib/setup b/test/lib/setup
index 3409bd29cd81..580825f1f9a7 100755
--- a/test/lib/setup
+++ b/test/lib/setup
@@ -264,7 +264,7 @@ setup_two_guests() {
                         -device virtio-net,netdev=v                            \
                         -object memory-backend-memfd,id=m,share=on,size=${__vmem} \
                         -numa node,memdev=m"
-               __qemu_netdev1="                                               \
+               __qemu_netdev2="                                               \
                         -chardev socket,id=c,path=${STATESETUP}/passt_2.socket \
                         -netdev vhost-user,id=v,chardev=c                      \
                         -device virtio-net,netdev=v                            \

Thanks,
Laurent