From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XbrY65BR; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 13E735A0262 for ; Fri, 21 Aug 2026 14:50:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787316644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qLdKPjDDzfaYVZGBRfjvSQT3uNfFf9M6uCo6vwtqWHU=; b=XbrY65BRSWWfjQEBdQgeJ92SKfcbya+xx0vSlDJRCm3014rXCZKuIeti5VqFLfIfbdhIbQ pw/MLwXo0XAwPHo1tn5b5npTzYiS7D71EXvqY4XvxId3dlzctZpdPjMkXDIQIraJT7WwQP NpiRl9yBlgm0qGtGdkIvjuLQoBC63TU= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-GrEEz2wjMJeaI_B6elOuTA-1; Fri, 21 Aug 2026 08:50:43 -0400 X-MC-Unique: GrEEz2wjMJeaI_B6elOuTA-1 X-Mimecast-MFC-AGG-ID: GrEEz2wjMJeaI_B6elOuTA_1787316642 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-c1630a90890so64551966b.1 for ; Fri, 21 Aug 2026 05:50:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787316642; x=1787921442; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qLdKPjDDzfaYVZGBRfjvSQT3uNfFf9M6uCo6vwtqWHU=; b=N2TOqOeUbZqr1yyUes+u81yHGEU5x+XxbkAEfO5x3EWyxPmVGXvYyQXxNsvmlV5nMr xVeZ7IcotzllWpKM28lkr9eyt02rmT9/mHpjp8DFKI2kUWSeDIt00PUiLqxNi36+daja wIfWcvbsFyxOf8NEu6hPhxvL5VSnXKGCGPoNq4nYfTLA3Bvj4en+mcIJbVYIpxvdTwwg gPHkyqKzZJryt+zxs5BG/KfoWk7tz/6meiAXUTFMQ2C6/pgzeBCQwZJ8TemWEGI+JNw4 5i70R5424YhU9nUaXEq0gndk6/YiI2CmmpManXk/bEKRp8ys/CHV4hz2hKuuNIonCsRj /uaw== X-Forwarded-Encrypted: i=1; AHgh+Ro26AFoHy+WujDCee0fjNCf0K9DOvxOT2ZrR0GcijVTeXKJDFfzbGr0CvlQOnVPpH14eWapyPZpgG4=@passt.top X-Gm-Message-State: AOJu0YytflBxM24FcwTTWp6C7ZSOyaBuX3NRe2LHMIcwsxB7wJN5xQpr jomg7PZP44HucL5qg8S7ioQmnJDjEN0iCBI230ClVgrB6mybZIOuMQAlriWtt9w1hgvqojQYTSD Ma6z+Ud2XLv2Q+VPvohebYIYbr9NBvNBFmHhIQUafrA7/vJXony78wSUKDnVp3cqr X-Gm-Gg: AR+sD12mJJlj7IEQlb9wq4lG9Njoz/8Yr6oaM9BFQ2FdhxJvKQ775L97biuRuO8OWMh YXwYtDp3cscWlJNmOxI/1JJ9/2OpqY1JuDmZ6VTxr54hRMpt4Z+CHb5QVkTd3puf6vrAGheloJk s8t99omgbiS+4WF72tINn9QT67TQd7TmsP5khTi0dSYQM6E5fQRZ+z8TTI7vq++vPWP7lR7LL+4 pCNFeXRy+3C/GSp1s9RFoNffWWPtqFVAKTRxJDwYkn0Ylrg7pToE1DZ5ZQL2cPTdYf0EGKuBI7J S4VUytA0KigpNEl99SO0P5rqsaK5CFF/WSRqKOMIhJamJGMmEAQoGpfcwwHHwo7nLig2C2YYt+x ZLu9QbobLj/tlJg8Osel81jaTmoue4GGK64JnbwyWGDKr X-Received: by 2002:a17:907:a703:b0:c16:13c3:b1ef with SMTP id a640c23a62f3a-c246a73b5b7mr689663766b.24.1787316642500; Fri, 21 Aug 2026 05:50:42 -0700 (PDT) X-Received: by 2002:a17:907:a703:b0:c16:13c3:b1ef with SMTP id a640c23a62f3a-c246a73b5b7mr689620666b.24.1787316639562; Fri, 21 Aug 2026 05:50:39 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:d92c:7e4a:47e6:1b23? ([2a01:e0a:e10:ef90:d92c:7e4a:47e6:1b23]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24591987e3sm482758766b.32.2026.08.21.05.50.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2026 05:50:38 -0700 (PDT) Message-ID: <1176c9e6-eda5-4803-82ff-bcc83a2fda5d@redhat.com> Date: Fri, 21 Aug 2026 14:50:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] clangd: Add _GNU_SOURCE to default clangd options To: David Gibson , Stefano Brivio , passt-dev@passt.top References: <20260821050403.170891-1-david@gibson.dropbear.id.au> <20260821050403.170891-2-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260821050403.170891-2-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KC_w8CW-QI9PPErx4IDMEgdftOOi6tRnAaNadE-oTTQ_1787316642 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: JZJET7QMYLFHPUDKVEQBANEPHPURYEYL X-Message-ID-Hash: JZJET7QMYLFHPUDKVEQBANEPHPURYEYL X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/21/26 07:03, David Gibson wrote: > We always insert -D_GNU_SOURCE and -D_XOPEN_SOURCE=700 when compiling from > the Makefile, and we rely on it. Without these listed in .clangd, clangd > will generate numerous spurious warnings. > > Signed-off-by: David Gibson > --- > .clangd | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.clangd b/.clangd > index 41bec92a..51baf737 100644 > --- a/.clangd > +++ b/.clangd > @@ -1,3 +1,3 @@ > CompileFlags: > # Don't try to interpret our headers as C++' > - Add: [-xc, -Wall] > + Add: [-xc, -Wall, -D_XOPEN_SOURCE=700, -D_GNU_SOURCE] Reviewed-by: Laurent Vivier