Re: [PATCH v2] spec: use %selinux_requires_min macro, drop overlapping dependencies

[Max Chernoff <git@maxchernoff.ca>]

Hi Danish,

On Fri, 2025-11-21 at 18:17 +0530, Danish Prakash wrote:
> Also, drop unused preun policycoreutils requires, and Recommends on
> selinux-policy-%{targeted}, it has since been added to
> %selinux_requires_min.
>
> Signed-off-by: Danish Prakash <contact@danishpraka.sh>

Reviewed-by: Max Chernoff <git@maxchernoff.ca>
Tested-by: Max Chernoff <git@maxchernoff.ca>

(I've only tested this on F43, but the non-F43 changes also look good to
me)

> ---
>  contrib/fedora/passt.spec | 26 ++++++++++++++------------
>  1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
> index d1bcf4a74338..bcbe1f77bb6c 100644
> --- a/contrib/fedora/passt.spec
> +++ b/contrib/fedora/passt.spec
> @@ -34,19 +34,21 @@ for network namespaces: traffic is forwarded using a tap interface inside the
>  namespace, without the need to create further interfaces on the host, hence not
>  requiring any capabilities or privileges.
>
> -%package		selinux
> -BuildArch:		noarch
> -Summary:		SELinux support for passt and pasta
> -Requires:		selinux-policy-%{selinuxtype}
> -Requires:		container-selinux
> -Requires(post):		selinux-policy-%{selinuxtype}
> +%package		    selinux
> +BuildArch:		    noarch
> +Summary:		    SELinux support for passt and pasta
> +%if 0%{?fedora} >= 43
> +BuildRequires:      selinux-policy-devel
> +%selinux_requires_min
> +%else
> +BuildRequires:      pkgconfig(systemd)
> +Requires(post):     libselinux-utils
> +Requires(post):     policycoreutils
> +%endif
> +Requires:		    container-selinux
> +Requires:		    selinux-policy-%{selinuxtype}
>  Requires(post):		container-selinux
> -Requires(post):		policycoreutils
> -Requires(post):		libselinux-utils
> -Requires(preun):	policycoreutils
> -BuildRequires:		selinux-policy-devel
> -BuildRequires:		pkgconfig(systemd)
> -Recommends:		selinux-policy-%{selinuxtype} >= %{selinux_policy_version}
> +Requires(post):		selinux-policy-%{selinuxtype}
>
>  %description selinux
>  This package adds SELinux enforcement to passt(1), pasta(1), passt-repair(1).

Thanks,
-- Max