From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=maxchernoff.ca Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=maxchernoff.ca header.i=@maxchernoff.ca header.a=rsa-sha256 header.s=key1 header.b=GjS2BVB/; dkim-atps=neutral Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [IPv6:2001:41d0:203:375::ab]) by passt.top (Postfix) with ESMTPS id C633A5A0271 for ; Sun, 23 Nov 2025 08:37:36 +0100 (CET) Message-ID: <12872851fcbd10d1c37d074ebf88daef07cc50a0.camel@maxchernoff.ca> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maxchernoff.ca; s=key1; t=1763883455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fvo4d9rs/7c7XZl7SjQ26GPl9fuCukm14lm3eUimwEY=; b=GjS2BVB/f1FGNDWYzMEzS7fng5Iza3aP/s3FxYmmMBdRBSBlcxpDg8FQ1XxWtFXcKW9QRJ WjMKhfj0tXXFsnu0mWMruk8Kyr86woCReN3HLHckjlXJKiFySmftD59kZkYcO82WtRFVUD Y9K11/ELz0h0ociWI8R7FDDvrpoCL2xE9Nl5D35Vng508uFy6OHk9i3MBdQhR7vDjA1D0e 8a/INxmlPfT+5/rrjXcwDMjrAoVDUwI6NTD06usRif8sP8l4qTYJPdjn6D69cRXoIYWG2j xzu7nE7uYosNNaDsjEsG0Ct+4EH7YkhsiLcYkauidq8hm8BNvPmKqMK64+PfHg== Subject: Re: [PATCH v2] spec: use %selinux_requires_min macro, drop overlapping dependencies X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Max Chernoff To: Danish Prakash , passt-dev@passt.top Date: Sun, 23 Nov 2025 00:37:24 -0700 In-Reply-To: <20251121124842.459206-1-contact@danishpraka.sh> References: <4c552ad9-ab11-4011-aee8-1f9f1246f863@redhat.com> <20251121124842.459206-1-contact@danishpraka.sh> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT Message-ID-Hash: 4MSA72C5FM5GW4FTJ3FP4RSUI7NLKIX2 X-Message-ID-Hash: 4MSA72C5FM5GW4FTJ3FP4RSUI7NLKIX2 X-MailFrom: git@maxchernoff.ca X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, pholzing@redhat.com, vmojzis@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Danish, On Fri, 2025-11-21 at 18:17 +0530, Danish Prakash wrote: > Also, drop unused preun policycoreutils requires, and Recommends on > selinux-policy-%{targeted}, it has since been added to > %selinux_requires_min. > > Signed-off-by: Danish Prakash Reviewed-by: Max Chernoff Tested-by: Max Chernoff (I've only tested this on F43, but the non-F43 changes also look good to me) > --- > contrib/fedora/passt.spec | 26 ++++++++++++++------------ > 1 file changed, 14 insertions(+), 12 deletions(-) > > diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec > index d1bcf4a74338..bcbe1f77bb6c 100644 > --- a/contrib/fedora/passt.spec > +++ b/contrib/fedora/passt.spec > @@ -34,19 +34,21 @@ for network namespaces: traffic is forwarded using a = tap interface inside the > namespace, without the need to create further interfaces on the host, he= nce not > requiring any capabilities or privileges. > > -%package selinux > -BuildArch: noarch > -Summary: SELinux support for passt and pasta > -Requires: selinux-policy-%{selinuxtype} > -Requires: container-selinux > -Requires(post): selinux-policy-%{selinuxtype} > +%package selinux > +BuildArch: noarch > +Summary: SELinux support for passt and pasta > +%if 0%{?fedora} >=3D 43 > +BuildRequires: selinux-policy-devel > +%selinux_requires_min > +%else > +BuildRequires: pkgconfig(systemd) > +Requires(post): libselinux-utils > +Requires(post): policycoreutils > +%endif > +Requires: container-selinux > +Requires: selinux-policy-%{selinuxtype} > Requires(post): container-selinux > -Requires(post): policycoreutils > -Requires(post): libselinux-utils > -Requires(preun): policycoreutils > -BuildRequires: selinux-policy-devel > -BuildRequires: pkgconfig(systemd) > -Recommends: selinux-policy-%{selinuxtype} >=3D %{selinux_policy_version= } > +Requires(post): selinux-policy-%{selinuxtype} > > %description selinux > This package adds SELinux enforcement to passt(1), pasta(1), passt-repai= r(1). Thanks, -- Max