From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QJOv3AzB; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 8F03E5A004E for ; Mon, 18 Nov 2024 17:47:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731948420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iTfwbkdaYRDfWmV3/TVSSOtB1coqZiI8Bw9L0dl2q68=; b=QJOv3AzBNXwF8ZhqkaVIeW/BwNadBZ5BE667Pvtcc3aCgzrZH1lQ1v1Vb4JWIztbxzvtev AcmPvPdmn6q28qOewYFZ02/1LDJJ466NEr+rjsgQbpozLgGb0uTedOKx3WOEle2GeL4EVo dpxxvikTbFzmPGFl0Bf67dtfQn7qpfU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-BwN1MUKgMBSUUrH4Hl3llg-1; Mon, 18 Nov 2024 11:46:57 -0500 X-MC-Unique: BwN1MUKgMBSUUrH4Hl3llg-1 X-Mimecast-MFC-AGG-ID: BwN1MUKgMBSUUrH4Hl3llg Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38231e6b4cbso1917096f8f.3 for ; Mon, 18 Nov 2024 08:46:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731948414; x=1732553214; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iTfwbkdaYRDfWmV3/TVSSOtB1coqZiI8Bw9L0dl2q68=; b=HvXetxltXA1msblmnizQDRz8K6BnBrGcnuww5YB7a0yYsP+MYVzalWFGxkxnbglZ+G 5WxU78/iCsGmyB/OGQaU3dZAlh3ttcHIaCoq7Wp29ykl5tqLJcsD8H6Kca9uJKyFJ1Wz vWdx6spVeuCitqIR/pKmtr35TyY28J741O5WLjeLM74JuMNi3cY7ytXIrV/xG0EqFPrU qBKHRGq0mtBJ14aV0Ehej/tSKCGeCkNm1gUuCTg6WH4yry6G8ZQD39EdqP4mAMd13BJI UMRYdkUVQKxzt5EMg0BjKI7gjMUnzUdfyhpkAXbrDaR6DGrJVS3R8Vhzq9KaNbpeBCWf FoVA== X-Gm-Message-State: AOJu0YzjtBkSefIA/r4zhq05p3ksPlon+1GaA/D/gvsFBNPxBm4LQB/x eGc1AdTyS8vdGFKHCMcJViNhcZ7s7K/c8Ll2U6ONbKPqtXsE+RUEaUIwrzGz/1ZfZqKGWH73ENN fmUFOEJOj+zV0OgbV9pj0+5jW0wJV2BRr7q1eMt/BI6Sn7aCd5g== X-Received: by 2002:a05:6000:156a:b0:382:4978:2a93 with SMTP id ffacd0b85a97d-38249782e8cmr3092610f8f.12.1731948414545; Mon, 18 Nov 2024 08:46:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEyQg/8KrKBxJk30mG0UgDv4Dpyp473OtumxJeihHXt/Nys4tXAou3GfW5MTuStoUzB0T3fA== X-Received: by 2002:a05:6000:156a:b0:382:4978:2a93 with SMTP id ffacd0b85a97d-38249782e8cmr3092593f8f.12.1731948414186; Mon, 18 Nov 2024 08:46:54 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38237441ccesm7626966f8f.51.2024.11.18.08.46.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Nov 2024 08:46:53 -0800 (PST) Message-ID: <128f391c-22ef-4c78-915c-2679ef320979@redhat.com> Date: Mon, 18 Nov 2024 17:46:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 00/10] Add vhost-user support to passt. (part 3) To: Stefano Brivio References: <20241115135850.1170744-1-lvivier@redhat.com> <20241115152540.6b63ac3e@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20241115152540.6b63ac3e@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5okDfTzJeYS2kq-ilps64eiO00d2w8-PBWv3g76Cza4_1731948414 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: TWWW6BM4THAALGFKGDK3YVXZ5ODP4MJT X-Message-ID-Hash: TWWW6BM4THAALGFKGDK3YVXZ5ODP4MJT X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 15/11/2024 15:25, Stefano Brivio wrote: > On Fri, 15 Nov 2024 14:58:38 +0100 > Laurent Vivier wrote: > >> v12: >> - rebase >> - address comments from Stefano > > ...including SO_PEEK_OFF fixes? Should I test that part already? :) > There are several bugs, the first one is the IP header checksum is wrong for the last frame, the following change fixes the problem: diff --git a/tcp_vu.c b/tcp_vu.c index 14093f502ba6..3f3c001c4e8e 100644 --- a/tcp_vu.c +++ b/tcp_vu.c @@ -459,7 +459,7 @@ int tcp_vu_data_from_sock(const struct ctx *c, struct tcp_p) if (frame_size >= mss || len == 0 || i + 1 == iov_cnt || !vu_has_feature(vdev, VIRTIO_NET_F_MRGX{ - if (i + 1 == iov_cnt) + if (i + 1 == iov_cnt || len == 0) check = NULL; /* restore first iovec base: point to vnet header */ Now, it doesn't hang but the transfer is truncated. I'm hunting the next one. Thanks, Laurent