From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BByHaIH5; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 9D5075A004E for ; Thu, 26 Sep 2024 15:41:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727358098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CCGNqpAkLkaxmqYmT3IUW+Wmr7yKtpQTNG/YqWIzJP0=; b=BByHaIH5B07FRMax8fLmldf8iKASSEgU63Y4jN/sfCyuTKZ/4rU5cfbQZRzLJ3lGBkywb+ MhJQvkNTrUuzT8wJW6NbFypkyrdG3nUfIh5V79+M38tGpWZqRRTFF9TXtE3kwSm1nnTPBK VU/JbsWD+IGx2PV5P6bN3fpe/jFYwko= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-493--v4JunymOKaDoPoSI5ajQQ-1; Thu, 26 Sep 2024 09:41:37 -0400 X-MC-Unique: -v4JunymOKaDoPoSI5ajQQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37ccd40aad4so410233f8f.2 for ; Thu, 26 Sep 2024 06:41:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727358095; x=1727962895; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CCGNqpAkLkaxmqYmT3IUW+Wmr7yKtpQTNG/YqWIzJP0=; b=MS8JtgIN8e3/t7wT/efff2GWYuEXj9irWiFrV4NlRWYsS6k6qvZ0U7orQXJ2xobdQO lto/1SjPyTUvY0+wQR/THWR4zZHKnE9OK7nwJuwFxQj2NL1J6qJA7DGJsvTGsgcA3kbf NqDw3v4eV4u2wM/z8mI3SuP9LbIfIVLqc3fwExRWUh0oFKOcX80jjWD9M+/FGRy1y6cW 0N8MLhGorS6SLlQ/wFKPP1+BpfXbE/0cXyqkrI8OU6SVPsb/UsUflEX4yoREPkGBc5QJ 3PgXaIPsGHFrMvnRnnkuMgM6KdJ9W3JdQDJGEVf/HxCTRzCfyB9hjKQT/C3axyNDwjk1 5GjA== X-Gm-Message-State: AOJu0Yy4DJmTmWsEbN84YKzEk8TyqkY8Nj6dhoYzl/BrFsl6q2fzWBNu uqp9gMzdia6L4fU6gTM4OFYN2m8tGmuGwO1CGe/fqqpRns5veTyo9VgO6IQ0fQTGOm+pEJ7mYc4 q3W+qihvg8Mp4KlmqSCnetn5eRgQkwEqtZrNRilUkQnK3FiAuUT2OS4PTiPHTvOCjaeWnXaV7hU 0D3MVHg35pSMkYrcQlFTn3TFIX/EtdA1Z4 X-Received: by 2002:adf:f742:0:b0:37c:d2f0:7331 with SMTP id ffacd0b85a97d-37cd2f074a3mr416756f8f.0.1727358095587; Thu, 26 Sep 2024 06:41:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/86lYvTCPUysn696wky7DU43fmanhD0XHOglclZRqHX4uhjV7uXlcHBJZS33gmQiItUb8qA== X-Received: by 2002:adf:f742:0:b0:37c:d2f0:7331 with SMTP id ffacd0b85a97d-37cd2f074a3mr416740f8f.0.1727358095067; Thu, 26 Sep 2024 06:41:35 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78? ([2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc2f9811sm6485975f8f.86.2024.09.26.06.41.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Sep 2024 06:41:34 -0700 (PDT) Message-ID: <12c6a1bf-a923-4a44-aeb1-3dc0092c4d7f@redhat.com> Date: Thu, 26 Sep 2024 15:41:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] tcp: Update TCP checksum using an iovec array To: passt-dev@passt.top References: <20240926132942.434962-1-lvivier@redhat.com> <20240926132942.434962-5-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20240926132942.434962-5-lvivier@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 5ICAHMNAV6W3GOP55JDISSFFGMWHABIK X-Message-ID-Hash: 5ICAHMNAV6W3GOP55JDISSFFGMWHABIK X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 26/09/2024 15:29, Laurent Vivier wrote: > TCP header and payload are supposed to be in the same buffer, > and tcp_update_check_tcp4()/tcp_update_check_tcp6() compute > the checksum from the base address of the header using the > length of the IP payload. > > In the future (for vhost-user) we need to dispatch the TCP header and > the TCP payload through several buffers. To be able to manage that, we > provide an iovec array that points to the data of the TCP frame. > We provide also an offset to be able to provide an array that contains > the TCP frame embedded in an lower level frame, and this offset points > to the TCP header inside the iovec array. > > Signed-off-by: Laurent Vivier > --- > checksum.c | 1 - > tcp.c | 127 +++++++++++++++++++++++++++++++++++++++++------------ > 2 files changed, 99 insertions(+), 29 deletions(-) ... > /** > * tcp_update_check_tcp6() - Calculate TCP checksum for IPv6 > - * @ip6h: IPv6 header > - * @bp: TCP header followed by TCP payload > - */ > -static void tcp_update_check_tcp6(const struct ipv6hdr *ip6h, > - struct tcp_payload_t *bp) > + * @src: IPv6 source address > + * @dst: IPv6 destination address > + * @iov: Pointer to the array of IO vectors > + * @iov_cnt: Length of the array > + * @l4offset: IPv6 payload offset in the iovec array > + */ > +void tcp_update_check_tcp6(const struct in6_addr *src, > + const struct in6_addr *dst, > + const struct iovec *iov, int iov_cnt, > + size_t l4offset) > { > - uint16_t l4len = ntohs(ip6h->payload_len); > - uint32_t sum = proto_ipv6_header_psum(l4len, IPPROTO_TCP, > - &ip6h->saddr, &ip6h->daddr); > + size_t check_ofs; > + __sum16 *check; > + int check_idx; > + uint32_t sum; > + > + sum = proto_ipv6_header_psum(iov_size(iov, iov_cnt) - l4offset, > + IPPROTO_TCP, src, dst); > > - bp->th.check = 0; > - bp->th.check = csum(bp, l4len, sum); > + check_idx = iov_skip_bytes(iov, iov_cnt, > + l4offset + offsetof(struct tcphdr, check), > + &check_ofs); > + > + if (check_idx >= iov_cnt) > + die("TCP6 buffer is too small"); > + if (check_ofs + sizeof(*check) > iov[check_idx].iov_len) > + die("TCP6 checksum field memory is not contiguous"); > + I'm going to resend, I forgot to update tcp_update_check_tcp6(). Laurent