From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id E6FAE5A0271 for ; Fri, 1 Mar 2024 13:06:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709294811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vtMRvPLcJU8wH0CxoULOvwDusXRqP30WQqSCA32SHrE=; b=EBBP4XUMd4CUD1A4FqgKf7tBC8EuExTH1rD+gcSJ0EcaoFe8+F70mNYZWV3pEwldOGAcqR M59btpixiwuWA8IgT5JgdTFzWAMhDe7b+mg23VB8pV3lKkurdt+5L8NPjn8jSkjJMMsxx+ aObxyDa4pnNjb9NZrTqRCRMPq1iunDc= Received: from mail-oa1-f71.google.com (mail-oa1-f71.google.com [209.85.160.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-327-M_v3DelhPUamEIL3qfjkqw-1; Fri, 01 Mar 2024 07:06:50 -0500 X-MC-Unique: M_v3DelhPUamEIL3qfjkqw-1 Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-21eafac0a98so1578396fac.2 for ; Fri, 01 Mar 2024 04:06:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709294810; x=1709899610; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vtMRvPLcJU8wH0CxoULOvwDusXRqP30WQqSCA32SHrE=; b=FIq4i5nvMq1IWAOdkQTTI68ePvT6WLNlpvLDF09b1v02SZqUHWhM2e9zKimbmNbTL1 L2YHdhC3abyNs57i+XPDASgTkrhTuwjQRhTMSMx12LspgTWcy9vdzs33grEdM0sz+w6d b2r0laZPiK/VYoeMOsgkUqJMCtwQqoLGp4s78/n5Xv5LaOQZfSx6e4TA2eIqfYdWwYXs HqjgTyI1D6CM11HQalGzKLb1x/yCpRkG/ezrXMEtZquPcgZcguaa+xLyBTJcjdIUbdgU Cub6suSq6/LWNLv5JpvAqmMC3OCLRTcER5eYtZrqfnSHZTrYcx/ErB83RuaObQf1vhXe UTPw== X-Gm-Message-State: AOJu0Yzv3TKLOucBhO2V+tve2YZ78ibA+RdTkVwaOp29WZ9x+KxyelrF 45EG7ENNFFRlXzpBvZrONATFl1qEnKkuABxbxknIOJJS6EuCMrhS0nlD7LH/fHckYHzYdyUqct0 VYuTu1s8JlDm1Tut5HGbCqBJumvBFdClSYBfTIDA0IKDvXAeIsOl108lfKQ== X-Received: by 2002:a05:6871:206:b0:21f:1f78:adc9 with SMTP id t6-20020a056871020600b0021f1f78adc9mr1383593oad.29.1709294809884; Fri, 01 Mar 2024 04:06:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IEEt3jc1tGaFkgpvOaVw/ceM2UapJZxiRY6M8GdZv0RgF9kpXI02cKmBeG6phxNQ05VVoV2Ew== X-Received: by 2002:a05:6871:206:b0:21f:1f78:adc9 with SMTP id t6-20020a056871020600b0021f1f78adc9mr1383569oad.29.1709294809513; Fri, 01 Mar 2024 04:06:49 -0800 (PST) Received: from [192.168.100.30] ([82.142.8.70]) by smtp.gmail.com with ESMTPSA id f12-20020ac8464c000000b0042c70c153f6sm1607175qto.91.2024.03.01.04.06.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Mar 2024 04:06:49 -0800 (PST) Message-ID: <1642c691-af65-4c13-8cf5-9ad895a707f3@redhat.com> Date: Fri, 1 Mar 2024 13:06:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/8] util: move IP stuff from util.[ch] to ip.[ch] To: David Gibson References: <20240229165955.829476-1-lvivier@redhat.com> <20240229165955.829476-5-lvivier@redhat.com> From: Laurent Vivier In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: HJJJKPH3EOTEQQNTZDRRR652IDNZ32S7 X-Message-ID-Hash: HJJJKPH3EOTEQQNTZDRRR652IDNZ32S7 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/1/24 00:19, David Gibson wrote: > On Thu, Feb 29, 2024 at 05:59:51PM +0100, Laurent Vivier wrote: >> Introduce ip.[ch] file to encapsulate IP protocol handling functions and >> structures. Modify various files to include the new header ip.h when >> it's needed. >> >> Signed-off-by: Laurent Vivier >> Reviewed-by: David Gibson >> --- >> >> Notes: >> v4: >> - rebase >> >> v3: >> - rewrap rationale >> - add David's R-b >> >> v2: >> - update rationale and comments >> >> Makefile | 10 +++--- >> conf.c | 1 + >> dhcp.c | 1 + >> flow.c | 1 + >> fwd.c | 1 + >> icmp.c | 1 + >> inany.c | 1 + >> ip.c | 72 +++++++++++++++++++++++++++++++++++++++++++ >> ip.h | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > Noe that ip.h exists, in4addr_loopback and in4addr_any should probably > go in there rather than inany.h. That can be a followup change > though. > Not sure they should be moved to ip.h: they depend on inany_loopback4 and inany_any4 that are both defined in inany.c and the structure inany_addr is defined in inany.h I think it's better to let them where they are. Thanks, Laurent