From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UZUcs3V9; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 9FE805A061B for ; Thu, 28 Nov 2024 13:57:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732798658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RRNWEG4fxtUkQaw9tJrm0Pv4zon0TQZ7rs4HqxfyGCM=; b=UZUcs3V9y0lmAfAgGV49Z6ON+/kcjcTSzjoasAnk+VYlzslByByN2RpB7M4KPPlKK331jT QsQ0tQPSkNrL5ezunAOf8duxB4RIKnG5ZxmpnsZZGsXs8CbDxBd+C/uqx7HmYgrhuyHjeB rPQ2ghJEn+n9LhVTALYORszQFLjrEvA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-Qsn4xtFwNpWKGEeon5rbnw-1; Thu, 28 Nov 2024 07:57:37 -0500 X-MC-Unique: Qsn4xtFwNpWKGEeon5rbnw-1 X-Mimecast-MFC-AGG-ID: Qsn4xtFwNpWKGEeon5rbnw Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3823326e95aso441378f8f.3 for ; Thu, 28 Nov 2024 04:57:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732798655; x=1733403455; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RRNWEG4fxtUkQaw9tJrm0Pv4zon0TQZ7rs4HqxfyGCM=; b=XbYn4zEIAPePtYwa8KdKX6bafvMrQo/ZJ6hHcyzrUuN5qC7Gwb2wVaPGM/vnXGDUCO rdQH7IIByYI2qSNE9FGJdTeyvxRz0xVZi5QSsU4m6NI/GzCwYVaV+KXlTY9ns9rjvwR5 4laR6nYdAF09LTCUVtSRNfMU3Nmg8+DO7m2lQqxiva6RvYvQtvGmtbkGZYhOZncEGcdF CqN58i005NODvnooQGY/NFkIUFlmuPk5vqHEOkzcFYzbXECTkf5NQtcZjNqSnIJK98iq 2Xe7HzKVExmmxU7KkyEqORbIdwBanHjVbDlOHeoFtyN9IlEdvSiDU/DQIvsVHWWihR/Q tkAQ== X-Gm-Message-State: AOJu0YyqWJZx6OaFNWBDhdYI0hM1dZP1F4no9zcvY2CMUtkF4YL/7yP2 gku+9st+q4aa2JZXqHEqhcvGdHFU1I1X5KBpM0ykA2oYSpaZRT1PJoN0F/PAMFLkW5nT7H8wxQK ZwANeIaeQ8ppN0/tONycLUOGw3GuZRGLM/DNuzphxHrqj7fi75Tqep811hg== X-Gm-Gg: ASbGncuxiVWtYYtrRuS07S0RO6zblIupMaYpHm3Gr948IBwYaLFaz10vddSvsn4vR1s m6+npZZYnGKFn35ClDApsVkASYe/GFeMOa3O1vI4h8r831X48MG4mNvYEVRafdeg+l+chm3o2g9 OO/47ivpmnnIR1EPa4uXjCuFjOQpjVRHdYL9H2wvBIzr9QLE0+KMybcvVZS7Cap1B27NecvLGlZ UJNH1eub6JGKJSyzLlxwDjhT+6nilRrWhVfSoPBFxNK64T3+6A5nyIEdD+PLLL1HUq7kRZgYm4y VCjPyoGbtrWU X-Received: by 2002:a5d:64e4:0:b0:382:4867:2de5 with SMTP id ffacd0b85a97d-385c6ebf4aemr5848085f8f.35.1732798655536; Thu, 28 Nov 2024 04:57:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEO7Pam//2UupBlpg6YJ2bqiqomVS1Rk/u+QGELz9dI7XlJg9m/B6WCw+7HXMCal/bcJyxPlg== X-Received: by 2002:a5d:64e4:0:b0:382:4867:2de5 with SMTP id ffacd0b85a97d-385c6ebf4aemr5848065f8f.35.1732798655131; Thu, 28 Nov 2024 04:57:35 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ccd68e85sm1603565f8f.82.2024.11.28.04.57.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2024 04:57:34 -0800 (PST) Message-ID: <1d7670f9-ae9f-46e2-864d-d36fe3947709@redhat.com> Date: Thu, 28 Nov 2024 13:57:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 7/9] vhost-user: add vhost-user To: David Gibson References: <20241122164337.3377854-1-lvivier@redhat.com> <20241122164337.3377854-8-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4SAKdkFh-o_LAc-B-xnijWRfnwNeiFBZE8pW6U28HKs_1732798656 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 3EHWINPPXEGS4M34OQPOI5YEQGR4J4TB X-Message-ID-Hash: 3EHWINPPXEGS4M34OQPOI5YEQGR4J4TB X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 26/11/2024 06:24, David Gibson wrote: >> static int udp_vu_sock_recv(const struct ctx *c, int s, uint32_t events, >> + bool v6, ssize_t *dlen) >> +{ >> + struct vu_dev *vdev = c->vdev; >> + struct vu_virtq *vq = &vdev->vq[VHOST_USER_RX_QUEUE]; >> + int iov_cnt, idx, iov_used; >> + struct msghdr msg = { 0 }; >> + size_t off, hdrlen; >> + >> + ASSERT(!c->no_udp); >> + >> + if (!(events & EPOLLIN)) >> + return 0; >> + >> + /* compute L2 header length */ >> + hdrlen = udp_vu_hdrlen(v6); >> + >> + vu_init_elem(elem, iov_vu, VIRTQUEUE_MAX_SIZE); >> + >> + iov_cnt = vu_collect(vdev, vq, elem, VIRTQUEUE_MAX_SIZE, >> + IP_MAX_MTU - sizeof(struct udphdr) + hdrlen, > I don't think this calculation is quite right, though it's probably > safe. At least for IPv4, IP_MAX_MTU includes the IP header itself, > but then you count that again in hdrlen. I think it would be semantically more correct to use "ETH_MAX_MTU + sizeof(struct virtio_net_hdr_mrg_rxbuf)", but as ETH_MAX_MTU and IP_MAX_MTU are both defined to USHRT_MAX I'm not sure how to compute the segment size... Thanks, Laurent