From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: [PATCH 4/6] Makefile: Tweak $(RM) usage Date: Tue, 14 Jun 2022 15:12:24 +1000 Message-ID: <20220614051226.195541-5-david@gibson.dropbear.id.au> In-Reply-To: <20220614051226.195541-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8833359420422322228==" --===============8833359420422322228== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit The use of rm commands in the clean and uninstall targets adds an explicit leading - to ignore errors. However the built-in RM variable in make is actually "rm -f" which already ignores errors, so the - isn't neccessary. Also replace ${RM} with $(RM) which is the more conventional form in Makefiles. Signed-off-by: David Gibson --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 760d458..f918bb8 100644 --- a/Makefile +++ b/Makefile @@ -121,7 +121,7 @@ valgrind: all .PHONY: clean clean: - -${RM} $(BIN) *.o seccomp.h pasta.1 \ + $(RM) $(BIN) *.o seccomp.h pasta.1 \ passt.tar passt.tar.gz *.deb *.rpm install: $(BIN) $(MANPAGES) @@ -130,8 +130,8 @@ install: $(BIN) $(MANPAGES) cp -d $(MANPAGES) $(DESTDIR)$(prefix)/share/man/man1 uninstall: - -${RM} $(BIN:%=$(DESTDIR)$(prefix)/bin/%) - -${RM} $(MANPAGES:%=$(DESTDIR)$(prefix)/share/man/man1/%) + $(RM) $(BIN:%=$(DESTDIR)$(prefix)/bin/%) + $(RM) $(MANPAGES:%=$(DESTDIR)$(prefix)/share/man/man1/%) pkgs: static tar cf passt.tar -P --xform 's//\/usr\/bin\//' $(BIN) -- 2.36.1 --===============8833359420422322228==--