From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: [PATCH 6/6] Makefile: Spell prefix as PREFIX Date: Tue, 14 Jun 2022 15:12:26 +1000 Message-ID: <20220614051226.195541-7-david@gibson.dropbear.id.au> In-Reply-To: <20220614051226.195541-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1956930138685729840==" --===============1956930138685729840== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Makefile conventions (at least in the GNUish world) tend to control the base install directory with the variable $(PREFIX) (all caps). The passt Makefile has the same thing but in lower case $(prefix). Capitalize it to match conventions. Signed-off-by: David Gibson --- Makefile | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index b0dde68..c334605 100644 --- a/Makefile +++ b/Makefile @@ -82,7 +82,7 @@ ifeq ($(shell :|$(CC) -fstack-protector-strong -S -xc - -o = - >/dev/null 2>&1; ec CFLAGS +=3D -fstack-protector-strong endif =20 -prefix ?=3D /usr/local +PREFIX ?=3D /usr/local =20 ifeq ($(TARGET_ARCH),X86_64) BIN :=3D passt passt.avx2 pasta pasta.avx2 qrap @@ -125,13 +125,13 @@ clean: passt.tar passt.tar.gz *.deb *.rpm =20 install: $(BIN) $(MANPAGES) - mkdir -p $(DESTDIR)$(prefix)/bin $(DESTDIR)$(prefix)/share/man/man1 - cp -d $(BIN) $(DESTDIR)$(prefix)/bin - cp -d $(MANPAGES) $(DESTDIR)$(prefix)/share/man/man1 + mkdir -p $(DESTDIR)$(PREFIX)/bin $(DESTDIR)$(PREFIX)/share/man/man1 + cp -d $(BIN) $(DESTDIR)$(PREFIX)/bin + cp -d $(MANPAGES) $(DESTDIR)$(PREFIX)/share/man/man1 =20 uninstall: - $(RM) $(BIN:%=3D$(DESTDIR)$(prefix)/bin/%) - $(RM) $(MANPAGES:%=3D$(DESTDIR)$(prefix)/share/man/man1/%) + $(RM) $(BIN:%=3D$(DESTDIR)$(PREFIX)/bin/%) + $(RM) $(MANPAGES:%=3D$(DESTDIR)$(PREFIX)/share/man/man1/%) =20 pkgs: static tar cf passt.tar -P --xform 's//\/usr\/bin\//' $(BIN) --=20 2.36.1 --===============1956930138685729840==--