* [PATCH] Makefile: Suppress unusedStructMember Cppcheck warning in dhcp.c
@ 2022-06-14 12:15 Stefano Brivio
0 siblings, 0 replies; only message in thread
From: Stefano Brivio @ 2022-06-14 12:15 UTC (permalink / raw)
To: passt-dev
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
New from Cppcheck 2.8: all the fields of struct msg that are not
directly manipulated are now reported as unused, which is kind of
correct as those fields are used as a blob "copied" from request
to response and not as separate fields.
However, keeping the message composition explicit is probably
desirable, and adding inline suppressions makes the whole thing
rather unreadable, so just suppress unusedStructMember warnings for
dhcp.c, while also adding a suppression for unmatched suppressions
to keep earlier versions of Cppcheck happy.
Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
---
Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index 9f2ec3a..b0de1ec 100644
--- a/Makefile
+++ b/Makefile
@@ -259,8 +259,10 @@ cppcheck: $(wildcard *.c) $(wildcard *.h)
--suppress=localtimeCalled:pcap.c \
--suppress=unusedStructMember:pcap.c \
--suppress=funcArgNamesDifferent:util.h \
+ --suppress=unusedStructMember:dhcp.c \
\
--suppress=unmatchedSuppression:conf.c \
+ --suppress=unmatchedSuppression:dhcp.c \
--suppress=unmatchedSuppression:passt.c \
--suppress=unmatchedSuppression:pcap.c \
--suppress=unmatchedSuppression:qrap.c \
--
@@ -259,8 +259,10 @@ cppcheck: $(wildcard *.c) $(wildcard *.h)
--suppress=localtimeCalled:pcap.c \
--suppress=unusedStructMember:pcap.c \
--suppress=funcArgNamesDifferent:util.h \
+ --suppress=unusedStructMember:dhcp.c \
\
--suppress=unmatchedSuppression:conf.c \
+ --suppress=unmatchedSuppression:dhcp.c \
--suppress=unmatchedSuppression:passt.c \
--suppress=unmatchedSuppression:pcap.c \
--suppress=unmatchedSuppression:qrap.c \
--
2.35.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-14 12:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14 12:15 [PATCH] Makefile: Suppress unusedStructMember Cppcheck warning in dhcp.c Stefano Brivio
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).