Re: [PATCH 1/5] tests: Use more explicit netcat options for distro/fedora tests

[Stefano Brivio <sbrivio@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1865 bytes --]

On Fri, 10 Jun 2022 12:32:41 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> distro/fedora contains two versions of the basic tests, used for different
> Fedora versions.  One uses explicit listening address for netcat in some
> extra places, the other does not.  Apparently the older netcat versions
> didn't require the explicit addresses.  Not supplying addresses doesn't
> test anything useful though, just a detail in netcat's behaviour.  So,
> it's cleaner to just always supply explicit addresses.
> 
> In addition, we're explicitly expecting the nmap version of ncat, also
> known as "ncat".  So, it's more explicit what we're after if we invoke it
> via that name rather than "nc", which will go via an /etc/alternatives
> link.
> 
> Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> ---
>  test/distro/fedora | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/test/distro/fedora b/test/distro/fedora
> index f2f8f27..b7f1e3b 100644
> --- a/test/distro/fedora
> +++ b/test/distro/fedora
> @@ -16,13 +16,13 @@ htools	wget virt-edit guestfish head sed cat kill
>  
>  # Quick pasta test: send message from init to ns, and from ns to init
>  def	distro_quick_pasta_test
> -host	(nc -6 -l -p 10000 > /tmp/init_msg; echo "from_init" | nc ::1 9999) &
> +host	(ncat -6 -l -p 10000 ::1 > /tmp/init_msg; echo "from_init" | ncat ::1 9999) &

This doesn't work:

  $ ncat -6 -l -p 9999 ::1 > /tmp/ns_msg &
  [1] 21
  $ Ncat: bind to ::1:31337: Address already in use. QUITTING.

because with ncat(1) '-p' doesn't specify the listening port -- I see that
you changed this to the right version for tests under 'pasta/', that works
fine. I fixed this up (together with the other occurrences), re-running
tests now, I can merge the fix-up directly.

-- 
Stefano