From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 1/6] Makefile: Avoid using wildcard sources
Date: Tue, 14 Jun 2022 16:45:00 +0200 [thread overview]
Message-ID: <20220614164500.3a90455e@elisabeth> (raw)
In-Reply-To: <20220614051226.195541-2-david@gibson.dropbear.id.au>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On Tue, 14 Jun 2022 15:12:21 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:
> The passt/pasta Makefile makes fairly heavy use of GNU make's $(wildcard)
> function to locate the sources and headers to build. Using wildcards for
> the things to compile is usually a bad idea though: if somehow you end up
> with a .c or .h file in your tree you didn't expect it can misbuild in an
> exceedingly confusing way. In particular this can sometimes happen if
> switching between releases / branches where files have been added or
> removed without 100% cleaning the tree.
Thanks for fixing this, I have to admit I hit this very issue all the
time ;)
--
Stefano
next prev parent reply other threads:[~2022-06-14 14:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 5:12 [PATCH 0/6] Assorted makefile cleanups David Gibson
2022-06-14 5:12 ` [PATCH 1/6] Makefile: Avoid using wildcard sources David Gibson
2022-06-14 14:45 ` Stefano Brivio [this message]
2022-06-14 5:12 ` [PATCH 2/6] Makefile: Use $(BIN) and $(MANPAGES) variable to simplify several targets David Gibson
2022-06-16 14:06 ` Stefano Brivio
2022-06-14 5:12 ` [PATCH 3/6] Makefile: Simplify pasta* targets with a pattern rule David Gibson
2022-06-14 5:12 ` [PATCH 4/6] Makefile: Tweak $(RM) usage David Gibson
2022-06-14 5:12 ` [PATCH 5/6] Makefile: Don't create extraneous -.s file David Gibson
2022-06-14 5:12 ` [PATCH 6/6] Makefile: Spell prefix as PREFIX David Gibson
2022-06-14 14:45 ` Stefano Brivio
2022-06-15 0:42 ` David Gibson
2022-06-20 7:44 ` [PATCH 0/6] Assorted makefile cleanups Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614164500.3a90455e@elisabeth \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).