From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH 1/6] Makefile: Avoid using wildcard sources Date: Tue, 14 Jun 2022 16:45:00 +0200 Message-ID: <20220614164500.3a90455e@elisabeth> In-Reply-To: <20220614051226.195541-2-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3426208277858069155==" --===============3426208277858069155== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Tue, 14 Jun 2022 15:12:21 +1000 David Gibson wrote: > The passt/pasta Makefile makes fairly heavy use of GNU make's $(wildcard) > function to locate the sources and headers to build. Using wildcards for > the things to compile is usually a bad idea though: if somehow you end up > with a .c or .h file in your tree you didn't expect it can misbuild in an > exceedingly confusing way. In particular this can sometimes happen if > switching between releases / branches where files have been added or > removed without 100% cleaning the tree. Thanks for fixing this, I have to admit I hit this very issue all the time ;) -- Stefano --===============3426208277858069155==--