From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 6/6] Makefile: Spell prefix as PREFIX
Date: Tue, 14 Jun 2022 16:45:05 +0200 [thread overview]
Message-ID: <20220614164505.5775bca0@elisabeth> (raw)
In-Reply-To: <20220614051226.195541-7-david@gibson.dropbear.id.au>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On Tue, 14 Jun 2022 15:12:26 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:
> Makefile conventions (at least in the GNUish world) tend to control the
> base install directory with the variable $(PREFIX) (all caps). The passt
> Makefile has the same thing but in lower case $(prefix). Capitalize it to
> match conventions.
I've been wondering about this when I first added it to the Makefile,
and I couldn't really find a rationale for it. From the documentation
of GNU make:
http://www.gnu.org/software/make/manual/make.html#Directory-Variables
http://www.gnu.org/software/make/manual/make.html#DESTDIR
prefix is (conventionally) lowercase, DESTDIR is uppercase, so I'd
stick to that. I guess there's just some historic reason behind it. Some
Makefiles of long-standing projects use prefix, some PREFIX.
By the way, the rest of the series all look good to me (and is very
appreciated!).
--
Stefano
next prev parent reply other threads:[~2022-06-14 14:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 5:12 [PATCH 0/6] Assorted makefile cleanups David Gibson
2022-06-14 5:12 ` [PATCH 1/6] Makefile: Avoid using wildcard sources David Gibson
2022-06-14 14:45 ` Stefano Brivio
2022-06-14 5:12 ` [PATCH 2/6] Makefile: Use $(BIN) and $(MANPAGES) variable to simplify several targets David Gibson
2022-06-16 14:06 ` Stefano Brivio
2022-06-14 5:12 ` [PATCH 3/6] Makefile: Simplify pasta* targets with a pattern rule David Gibson
2022-06-14 5:12 ` [PATCH 4/6] Makefile: Tweak $(RM) usage David Gibson
2022-06-14 5:12 ` [PATCH 5/6] Makefile: Don't create extraneous -.s file David Gibson
2022-06-14 5:12 ` [PATCH 6/6] Makefile: Spell prefix as PREFIX David Gibson
2022-06-14 14:45 ` Stefano Brivio [this message]
2022-06-15 0:42 ` David Gibson
2022-06-20 7:44 ` [PATCH 0/6] Assorted makefile cleanups Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614164505.5775bca0@elisabeth \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).