From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH 6/6] Makefile: Spell prefix as PREFIX Date: Tue, 14 Jun 2022 16:45:05 +0200 Message-ID: <20220614164505.5775bca0@elisabeth> In-Reply-To: <20220614051226.195541-7-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7642264437979349993==" --===============7642264437979349993== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Tue, 14 Jun 2022 15:12:26 +1000 David Gibson wrote: > Makefile conventions (at least in the GNUish world) tend to control the > base install directory with the variable $(PREFIX) (all caps). The passt > Makefile has the same thing but in lower case $(prefix). Capitalize it to > match conventions. I've been wondering about this when I first added it to the Makefile, and I couldn't really find a rationale for it. From the documentation of GNU make: http://www.gnu.org/software/make/manual/make.html#Directory-Variables http://www.gnu.org/software/make/manual/make.html#DESTDIR prefix is (conventionally) lowercase, DESTDIR is uppercase, so I'd stick to that. I guess there's just some historic reason behind it. Some Makefiles of long-standing projects use prefix, some PREFIX. By the way, the rest of the series all look good to me (and is very appreciated!). -- Stefano --===============7642264437979349993==--