public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 2/6] Makefile: Use $(BIN) and $(MANPAGES) variable to simplify several targets
Date: Thu, 16 Jun 2022 16:06:46 +0200	[thread overview]
Message-ID: <20220616160646.02a0a338@elisabeth> (raw)
In-Reply-To: <20220614051226.195541-3-david@gibson.dropbear.id.au>

[-- Attachment #1: Type: text/plain, Size: 2271 bytes --]

On Tue, 14 Jun 2022 15:12:22 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> There are several places which explicitly list the various generated
> binaries, even though a $(BIN) variable already lists them.  There are
> several more places that list all the manpage files, introduce a
> $(MANPAGES) variable to remove that repetition as well.

This also needs (sorry ;))

diff --git a/test/distro/debian b/test/distro/debian
index f748dea..239e225 100644
--- a/test/distro/debian
+++ b/test/distro/debian
@@ -39,7 +39,7 @@ endef
 hostb  ./passt -P __PIDFILE__ &
 sleep  1
 host   echo
-hout   GUEST_FILES ls -1 *.c *.h *.sh Makefile | tr '\n' ' '; echo
+hout   GUEST_FILES ls -1 *.c *.h *.sh passt.1 qrap.1 Makefile | tr '\n' ' '; echo
 
 
 test   Debian GNU/Linux 8 (jessie), amd64
diff --git a/test/distro/fedora b/test/distro/fedora
index 7a5eaef..013cb45 100644
--- a/test/distro/fedora
+++ b/test/distro/fedora
@@ -60,7 +60,7 @@ hostb ./passt -P __PIDFILE__ &
 sleep  1
 host   echo
 hout   DNS6 sed -n 's/^nameserver \([^:]*:\)\([^%]*\).*/\1\2/p' /etc/resolv.conf | head -1
-hout   GUEST_FILES ls -1 *.c *.h *.sh Makefile | tr '\n' ' '; echo
+hout   GUEST_FILES ls -1 *.c *.h *.sh passt.1 qrap.1 Makefile | tr '\n' ' '; echo
 
 
 test   Fedora 26, x86_64
diff --git a/test/distro/opensuse b/test/distro/opensuse
index 39f059a..3d71c42 100644
--- a/test/distro/opensuse
+++ b/test/distro/opensuse
@@ -39,7 +39,7 @@ hostb ./passt -P __PIDFILE__ &
 sleep  1
 host   echo
 hout   DNS6 sed -n 's/^nameserver \([^:]*:\)\([^%]*\).*/\1\2/p' /etc/resolv.conf | head -1
-hout   GUEST_FILES ls -1 *.c *.h *.sh Makefile | tr '\n' ' '; echo
+hout   GUEST_FILES ls -1 *.c *.h *.sh passt.1 qrap.1 Makefile | tr '\n' ' '; echo
 
 
 test   OpenSUSE Leap 15.1
diff --git a/test/distro/ubuntu b/test/distro/ubuntu
index c9a2b4d..c3d1630 100644
--- a/test/distro/ubuntu
+++ b/test/distro/ubuntu
@@ -38,7 +38,7 @@ endef
 hostb  ./passt -P __PIDFILE__ &
 sleep  1
 host   echo
-hout   GUEST_FILES ls -1 *.c *.h *.sh Makefile | tr '\n' ' '; echo
+hout   GUEST_FILES ls -1 *.c *.h *.sh passt.1 qrap.1 Makefile | tr '\n' ' '; echo
 
 
 test   Ubuntu 14.04.5 LTS (Trusty Tahr), amd64

...added.

-- 
@@ -38,7 +38,7 @@ endef
 hostb  ./passt -P __PIDFILE__ &
 sleep  1
 host   echo
-hout   GUEST_FILES ls -1 *.c *.h *.sh Makefile | tr '\n' ' '; echo
+hout   GUEST_FILES ls -1 *.c *.h *.sh passt.1 qrap.1 Makefile | tr '\n' ' '; echo
 
 
 test   Ubuntu 14.04.5 LTS (Trusty Tahr), amd64

...added.

-- 
Stefano


  reply	other threads:[~2022-06-16 14:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  5:12 [PATCH 0/6] Assorted makefile cleanups David Gibson
2022-06-14  5:12 ` [PATCH 1/6] Makefile: Avoid using wildcard sources David Gibson
2022-06-14 14:45   ` Stefano Brivio
2022-06-14  5:12 ` [PATCH 2/6] Makefile: Use $(BIN) and $(MANPAGES) variable to simplify several targets David Gibson
2022-06-16 14:06   ` Stefano Brivio [this message]
2022-06-14  5:12 ` [PATCH 3/6] Makefile: Simplify pasta* targets with a pattern rule David Gibson
2022-06-14  5:12 ` [PATCH 4/6] Makefile: Tweak $(RM) usage David Gibson
2022-06-14  5:12 ` [PATCH 5/6] Makefile: Don't create extraneous -.s file David Gibson
2022-06-14  5:12 ` [PATCH 6/6] Makefile: Spell prefix as PREFIX David Gibson
2022-06-14 14:45   ` Stefano Brivio
2022-06-15  0:42     ` David Gibson
2022-06-20  7:44 ` [PATCH 0/6] Assorted makefile cleanups Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220616160646.02a0a338@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).