From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 2/6] Makefile: Use $(BIN) and $(MANPAGES) variable to
 simplify several targets
Date: Thu, 16 Jun 2022 16:06:46 +0200
Message-ID: <20220616160646.02a0a338@elisabeth>
In-Reply-To: <20220614051226.195541-3-david@gibson.dropbear.id.au>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2993171401420083099=="

--===============2993171401420083099==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 14 Jun 2022 15:12:22 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> There are several places which explicitly list the various generated
> binaries, even though a $(BIN) variable already lists them.  There are
> several more places that list all the manpage files, introduce a
> $(MANPAGES) variable to remove that repetition as well.

This also needs (sorry ;))

diff --git a/test/distro/debian b/test/distro/debian
index f748dea..239e225 100644
--- a/test/distro/debian
+++ b/test/distro/debian
@@ -39,7 +39,7 @@ endef
 hostb  ./passt -P __PIDFILE__ &
 sleep  1
 host   echo
-hout   GUEST_FILES ls -1 *.c *.h *.sh Makefile | tr '\n' ' '; echo
+hout   GUEST_FILES ls -1 *.c *.h *.sh passt.1 qrap.1 Makefile | tr '\n' ' ';=
 echo
=20
=20
 test   Debian GNU/Linux 8 (jessie), amd64
diff --git a/test/distro/fedora b/test/distro/fedora
index 7a5eaef..013cb45 100644
--- a/test/distro/fedora
+++ b/test/distro/fedora
@@ -60,7 +60,7 @@ hostb ./passt -P __PIDFILE__ &
 sleep  1
 host   echo
 hout   DNS6 sed -n 's/^nameserver \([^:]*:\)\([^%]*\).*/\1\2/p' /etc/resolv.=
conf | head -1
-hout   GUEST_FILES ls -1 *.c *.h *.sh Makefile | tr '\n' ' '; echo
+hout   GUEST_FILES ls -1 *.c *.h *.sh passt.1 qrap.1 Makefile | tr '\n' ' ';=
 echo
=20
=20
 test   Fedora 26, x86_64
diff --git a/test/distro/opensuse b/test/distro/opensuse
index 39f059a..3d71c42 100644
--- a/test/distro/opensuse
+++ b/test/distro/opensuse
@@ -39,7 +39,7 @@ hostb ./passt -P __PIDFILE__ &
 sleep  1
 host   echo
 hout   DNS6 sed -n 's/^nameserver \([^:]*:\)\([^%]*\).*/\1\2/p' /etc/resolv.=
conf | head -1
-hout   GUEST_FILES ls -1 *.c *.h *.sh Makefile | tr '\n' ' '; echo
+hout   GUEST_FILES ls -1 *.c *.h *.sh passt.1 qrap.1 Makefile | tr '\n' ' ';=
 echo
=20
=20
 test   OpenSUSE Leap 15.1
diff --git a/test/distro/ubuntu b/test/distro/ubuntu
index c9a2b4d..c3d1630 100644
--- a/test/distro/ubuntu
+++ b/test/distro/ubuntu
@@ -38,7 +38,7 @@ endef
 hostb  ./passt -P __PIDFILE__ &
 sleep  1
 host   echo
-hout   GUEST_FILES ls -1 *.c *.h *.sh Makefile | tr '\n' ' '; echo
+hout   GUEST_FILES ls -1 *.c *.h *.sh passt.1 qrap.1 Makefile | tr '\n' ' ';=
 echo
=20
=20
 test   Ubuntu 14.04.5 LTS (Trusty Tahr), amd64

...added.

--=20
Stefano


--===============2993171401420083099==--