Re: [PATCH 5/5] tests: Use nmap-ncat instead of openbsd netcat for pasta tests

[Stefano Brivio <sbrivio@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2366 bytes --]

On Fri, 10 Jun 2022 12:32:45 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> A number of the testcases use options specific the OpenBSD version of
> netcat.  That's available in Debian, but not easily available in Fedora.
> Switch the pasta tests to using the nmap version of netcat (a.k.a. ncat).
> This is easily available in both Debian and Fedora, and appears to be a
> bit more modern and maintained as well.
> 
> ncat generally requires explicit listen addresses (which is good for
> clarity anywhere).  Its default options appear to remove the need for the
> -N and -q options.
> 
> Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> ---
>  test/README.md  |  2 +-
>  test/demo/pasta | 12 ++++++------
>  test/tcp/pasta  | 52 ++++++++++++++++++++++++-------------------------
>  test/udp/pasta  | 29 ++++++++++++++-------------
>  4 files changed, 48 insertions(+), 47 deletions(-)
> 
> diff --git a/test/README.md b/test/README.md
> index 362690c..201332b 100644
> --- a/test/README.md
> +++ b/test/README.md
> @@ -29,7 +29,7 @@ on a system, i.e. common utilities such as a shell are not included here.
>  Example for Debian, and possibly most Debian-based distributions:
>  
>      build-essential git jq strace iperf3 qemu-system-x86 tmux sipcalc bc
> -    clang-tidy cppcheck isc-dhcp-common psmisc linux-cpupower
> +    clang-tidy cppcheck isc-dhcp-common psmisc linux-cpupower ncat
>      netcat-openbsd fakeroot lz4 lm-sensors qemu-system-arm qemu-system-ppc
>      qemu-system-misc qemu-system-x86 valgrind
>  
> diff --git a/test/demo/pasta b/test/demo/pasta
> index e2517ed..de1bdc5 100644
> --- a/test/demo/pasta
> +++ b/test/demo/pasta
> @@ -100,9 +100,9 @@ nl
>  say	  pasta detects bound ports and forwards them.
>  sleep	3
>  
> -nsb	nc -6 -l -p 31337
> +nsb	ncat -6 -l ::1 31337
>  sleep	2
> -host	echo "Hello from the host" | nc -N ::1 31337
> +host	echo "Hello from the host" | ncat ::1 31337
>  sleep	5
>  
>  nl
> @@ -111,9 +111,9 @@ say	Now the other way around...
>  nl
>  say	  we can use a loopback address
>  sleep	2
> -hostb	nc -l -p 31337
> +hostb	ncat -l ::1 31337
>  sleep	2
> -ns	echo "Hello from the namespace" | nc -N 127.0.0.1 31337
> +ns	echo "Hello from the namespace" | ncat 127.0.0.1 31337

...changing this to ::1. :)

-- 
Stefano