public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: [PATCH v2 0/4] New line reading implementation
Date: Fri, 24 Jun 2022 12:17:28 +1000	[thread overview]
Message-ID: <20220624021732.4062212-1-david@gibson.dropbear.id.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

As discussed on our call, the current line_read() implementation is
pretty ugly and has some definite bugs.  This series replaces it with
a new implementation which should be more solid and more readable.

The new implementation is larger than I'd really like, but it turns
out its fiddlier to handle the various edge cases than you might
think.

David Gibson (4):
  Add cleaner line-by-line reading primitives
  Parse resolv.conf with new lineread implementation
  Use new lineread implementation for procfs_scan_listen()
  Remove unused line_read()

 Makefile   |   8 ++--
 conf.c     |  22 ++++++----
 lineread.c | 115 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 lineread.h |  31 +++++++++++++++
 util.c     |  64 +++--------------------------
 5 files changed, 170 insertions(+), 70 deletions(-)
 create mode 100644 lineread.c
 create mode 100644 lineread.h

-- 
2.36.1


             reply	other threads:[~2022-06-24  2:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24  2:17 David Gibson [this message]
2022-06-24  2:17 ` [PATCH v2 1/4] Add cleaner line-by-line reading primitives David Gibson
2022-06-27 10:36   ` Stefano Brivio
2022-06-28  0:47     ` David Gibson
2022-06-24  2:17 ` [PATCH v2 2/4] Parse resolv.conf with new lineread implementation David Gibson
2022-06-24  2:17 ` [PATCH v2 3/4] Use new lineread implementation for procfs_scan_listen() David Gibson
2022-06-24  2:17 ` [PATCH v2 4/4] Remove unused line_read() David Gibson
2022-07-06 17:46 ` [PATCH v2 0/4] New line reading implementation Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624021732.4062212-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).