More mbuto pain

More mbuto pain

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

Now that the mbuto profile change is around, I tried getting the passt
tests working.  I fixed a couple of minor problems, before hitting
another mbuto issue.

On my host, mbuto isn't managing to find and include the virtio_net
module.  I think this is because on current Fedora the modules in
/lib/modules are compressed.  So it needs to include:
    /lib/modules/5.18.6-200.fc36.x86_64/kernel/drivers/net/virtio_net.ko.xz
but I think it's only looking for a plain '.ko' file.

I had a look at the mbuto code to see if I could fix it, but I'm
afraid mbuto is a long way past the complexity level at which I find
shell remotely comprehensible.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: More mbuto pain

[Stefano Brivio]

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

[Adding Sevinj... if you have some time to have a look]

On Tue, 28 Jun 2022 15:31:23 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> Now that the mbuto profile change is around, I tried getting the passt
> tests working.  I fixed a couple of minor problems, before hitting
> another mbuto issue.
> 
> On my host, mbuto isn't managing to find and include the virtio_net
> module.  I think this is because on current Fedora the modules in
> /lib/modules are compressed.  So it needs to include:
>     /lib/modules/5.18.6-200.fc36.x86_64/kernel/drivers/net/virtio_net.ko.xz
> but I think it's only looking for a plain '.ko' file.

Correct. I guess all it takes is to accept .ko, .ko.gz, .ko.xz, perhaps
something else in these expressions:

	__t="$(${BASENAME} -- "${__t%*.ko}")"

	__src="$(${FIND} ${__find_path}	-name "${__t}.ko")"

in kmod_add(), but I haven't tried yet.

> I had a look at the mbuto code to see if I could fix it, but I'm
> afraid mbuto is a long way past the complexity level at which I find
> shell remotely comprehensible.

-- 
Stefano

Re: More mbuto pain

[Sevinj Aghayeva]

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]

Sure, I will take a look.

On Tue, Jun 28, 2022 at 3:17 AM Stefano Brivio <sbrivio(a)redhat.com> wrote:

> [Adding Sevinj... if you have some time to have a look]
>
> On Tue, 28 Jun 2022 15:31:23 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
>
> > Now that the mbuto profile change is around, I tried getting the passt
> > tests working.  I fixed a couple of minor problems, before hitting
> > another mbuto issue.
> >
> > On my host, mbuto isn't managing to find and include the virtio_net
> > module.  I think this is because on current Fedora the modules in
> > /lib/modules are compressed.  So it needs to include:
> >
>  /lib/modules/5.18.6-200.fc36.x86_64/kernel/drivers/net/virtio_net.ko.xz
> > but I think it's only looking for a plain '.ko' file.
>
> Correct. I guess all it takes is to accept .ko, .ko.gz, .ko.xz, perhaps
> something else in these expressions:
>
>         __t="$(${BASENAME} -- "${__t%*.ko}")"
>
>         __src="$(${FIND} ${__find_path} -name "${__t}.ko")"
>
> in kmod_add(), but I haven't tried yet.
>
> > I had a look at the mbuto code to see if I could fix it, but I'm
> > afraid mbuto is a long way past the complexity level at which I find
> > shell remotely comprehensible.
>
> --
> Stefano
>
>

-- 

Sevinj.Aghayeva



[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 1918 bytes --]

Re: More mbuto pain

[Stefano Brivio]

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

Hello again,

On Tue, 28 Jun 2022 15:31:23 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> Now that the mbuto profile change is around, I tried getting the passt
> tests working.  I fixed a couple of minor problems, before hitting
> another mbuto issue.
> 
> On my host, mbuto isn't managing to find and include the virtio_net
> module.  I think this is because on current Fedora the modules in
> /lib/modules are compressed.  So it needs to include:
>     /lib/modules/5.18.6-200.fc36.x86_64/kernel/drivers/net/virtio_net.ko.xz
> but I think it's only looking for a plain '.ko' file.
> 
> I had a look at the mbuto code to see if I could fix it, but I'm
> afraid mbuto is a long way past the complexity level at which I find
> shell remotely comprehensible.

Sorry for the delay, I finally tried this out on a Fedora Cloud Base
image, 36-1.5.

There, mbuto actually finds virtio_net (because module paths are
obtained via 'modprobe'), but it won't parse the dependencies, so the
module would fail to load -- I just shared the patch to fix that part.

If it still fails for you, could you add a "set -x", "set +x" pair
around kmod_add() and share the result? Thanks,

-- 
Stefano