From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH v2 0/4] New line reading implementation Date: Wed, 06 Jul 2022 19:46:25 +0200 Message-ID: <20220706194625.10f35f96@elisabeth> In-Reply-To: <20220624021732.4062212-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2933800937640802827==" --===============2933800937640802827== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Fri, 24 Jun 2022 12:17:28 +1000 David Gibson wrote: > As discussed on our call, the current line_read() implementation is > pretty ugly and has some definite bugs. This series replaces it with > a new implementation which should be more solid and more readable. > > The new implementation is larger than I'd really like, but it turns > out its fiddlier to handle the various edge cases than you might > think. > > David Gibson (4): > Add cleaner line-by-line reading primitives > Parse resolv.conf with new lineread implementation > Use new lineread implementation for procfs_scan_listen() > Remove unused line_read() > > Makefile | 8 ++-- > conf.c | 22 ++++++---- > lineread.c | 115 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > lineread.h | 31 +++++++++++++++ > util.c | 64 +++-------------------------- > 5 files changed, 170 insertions(+), 70 deletions(-) > create mode 100644 lineread.c > create mode 100644 lineread.h Applied, finally, sorry for the delay! -- Stefano --===============2933800937640802827==--