Re: [PATCH] Fix parsing of LINKS

[Stefano Brivio <sbrivio@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

On Wed,  6 Jul 2022 17:23:23 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> Currently mbuto misparses the LINKS variable in the profile.  It will
> correctly assign the first two tokens to the target and link name, but for
> subsequent tokens ${__target} will always be non-empty, and so we'll never
> change it for later links.
> 
> AFAICT this has been missed because the existing sample profiles only have
> links all going to the same target.

Right, I didn't think of this problem at all.

> Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> ---
>  mbuto | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mbuto b/mbuto
> index 4ffe549..7530c72 100755
> --- a/mbuto
> +++ b/mbuto
> @@ -808,6 +808,7 @@ prog_add() {
>  		prog_link "${1}" \
>  			  "${__bindir##${wd}}/$("${BASENAME}" "${__bin}")" \
>  			  "${__target}" "${__l}"
> +		__target=
>  	done
>  
>  	libs_copy "${__bin}"

Merged now, thanks.

-- 
Stefano