From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH] Fix parsing of LINKS
Date: Wed, 06 Jul 2022 19:50:15 +0200
Message-ID: <20220706195015.5be75028@elisabeth>
In-Reply-To: <20220706072323.596133-1-david@gibson.dropbear.id.au>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3849029169068333384=="

--===============3849029169068333384==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Wed,  6 Jul 2022 17:23:23 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> Currently mbuto misparses the LINKS variable in the profile.  It will
> correctly assign the first two tokens to the target and link name, but for
> subsequent tokens ${__target} will always be non-empty, and so we'll never
> change it for later links.
> 
> AFAICT this has been missed because the existing sample profiles only have
> links all going to the same target.

Right, I didn't think of this problem at all.

> Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> ---
>  mbuto | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mbuto b/mbuto
> index 4ffe549..7530c72 100755
> --- a/mbuto
> +++ b/mbuto
> @@ -808,6 +808,7 @@ prog_add() {
>  		prog_link "${1}" \
>  			  "${__bindir##${wd}}/$("${BASENAME}" "${__bin}")" \
>  			  "${__target}" "${__l}"
> +		__target=
>  	done
>  
>  	libs_copy "${__bin}"

Merged now, thanks.

-- 
Stefano


--===============3849029169068333384==--