public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 00/15] Test fixes, batch 4
Date: Wed, 13 Jul 2022 08:04:14 +0200	[thread overview]
Message-ID: <20220713080414.2dd19657@elisabeth> (raw)
In-Reply-To: <Ys4pzJBbJuwy5xsU@yekko>

[-- Attachment #1: Type: text/plain, Size: 2280 bytes --]

On Wed, 13 Jul 2022 12:11:24 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> On Tue, Jul 12, 2022 at 02:13:07PM +0200, Stefano Brivio wrote:
> > On Tue, 12 Jul 2022 18:26:37 +1000
> > David Gibson <david(a)gibson.dropbear.id.au> wrote:
> >   
> > > On Mon, Jul 11, 2022 at 11:42:09AM +0200, Stefano Brivio wrote:  
> > > > On Thu, 7 Jul 2022 16:53:11 +0200
> > > > Stefano Brivio <sbrivio(a)redhat.com> wrote:
> > > >     
> > > > > [...]
> > > > >
> > > > > I'm running the tests now, let's see. :)    
> > > > 
> > > > For some reason qemu refuses to boot the OpenSUSE Leap 15.1 image made
> > > > this way, I haven't really looked into that yet.    
> > > 
> > > Huh.  I ran into a bunch of problems with the OpenSUSE Leap images
> > > when I tried to do the image preparation stuff for them.  But when I
> > > rolled that back and just did the image download separate, it seemed
> > > to work for me.  Well... that is, it boots up and executes commands
> > > okay.  
> > 
> > Ah, wait a moment, did you perhaps forget to commit the
> > distro/opensuse part for patch 14/15? The changes for distro/debian and
> > distro/fedora in that patch look complete, distro/ubuntu has changes
> > just for two versions, and distro/opensuse is not changed by that patch
> > at all.  
> 
> No.  I fiddled around with handling the SuSE and older Ubuntu images,
> got bogged down in details and decided to postpone that until a later
> time.  So I'm deliberately only handling the images which can be
> handled by the common script I added there for now.
> 
> > It took me a bit to figure out because the prepared images actually
> > work, but the test doesn't use them -- it's trying to use a temporary
> > file that doesn't exist anymore.  
> 
> Um, what prepared images? AFAICT my Makefile only generates prepared
> images for Debian, Fedora and the newer Ubuntu cases.  For SuSE and
> the older Ubuntu the test scripts now have qemu-img commands creating
> temporary images from the pre-downlaoded images (added in patch 13/15).

Oops, right, I missed that, I was confused by the fact that the image
didn't exist.

I guess DOWNLOAD_ASSETS (from patch 13/15) in test/Makefile should also
include OPENSUSE_IMGS, that's all. Added, re-running the whole thing
now.

-- 
Stefano


  reply	other threads:[~2022-07-13  6:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  7:28 [PATCH 00/15] Test fixes, batch 4 David Gibson
2022-07-06  7:28 ` [PATCH 01/15] test: Add external mbuto profile, drop udhcpc, and switch to it David Gibson
2022-07-06  7:28 ` [PATCH 02/15] Handle the case of a DNS server on localhost David Gibson
2022-07-06  7:28 ` [PATCH 03/15] tests: qemu-system-ppc64le isn't a thing David Gibson
2022-07-06  7:28 ` [PATCH 04/15] Invoke specific qemu-system-* binaries David Gibson
2022-07-06  7:28 ` [PATCH 05/15] tests: Introduce makefile for building test assets David Gibson
2022-07-06  7:29 ` [PATCH 06/15] tests: Move mbuto download and execution to asset build David Gibson
2022-07-06  7:29 ` [PATCH 07/15] tests: Search multiple places for aarch64 EDK2 bios image David Gibson
2022-07-06  7:29 ` [PATCH 08/15] Clean up passt.pid file David Gibson
2022-07-06  7:29 ` [PATCH 09/15] tests: Remove unused set_mode() function David Gibson
2022-07-06  7:29 ` [PATCH 10/15] tests: Remove not-very-useful "req" directive David Gibson
2022-07-06  7:29 ` [PATCH 11/15] tests: Don't automatically traverse directories of test files David Gibson
2022-07-06  7:29 ` [PATCH 12/15] tests: Explicitly list test files in test/run, remove "onlyfor" support David Gibson
2022-07-06  7:29 ` [PATCH 13/15] tests: Move distro image download to asset build makefile David Gibson
2022-07-06  7:29 ` [PATCH 14/15] tests: Prepare distro images during asset build phase David Gibson
2022-07-06  7:29 ` [PATCH 15/15] tests: Remove unused DNS6 calculation from fedora tests David Gibson
2022-07-07 14:53 ` [PATCH 00/15] Test fixes, batch 4 Stefano Brivio
2022-07-11  9:42   ` Stefano Brivio
2022-07-12  8:26     ` David Gibson
2022-07-12 12:13       ` Stefano Brivio
2022-07-13  2:11         ` David Gibson
2022-07-13  6:04           ` Stefano Brivio [this message]
2022-07-13 10:19             ` David Gibson
2022-07-13 23:39 ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713080414.2dd19657@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).