From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: [PATCH 2/7] Separately locate external interfaces for IPv4 and IPv6 Date: Fri, 22 Jul 2022 15:31:13 +1000 Message-ID: <20220722053118.1067459-3-david@gibson.dropbear.id.au> In-Reply-To: <20220722053118.1067459-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2744484522412582348==" --===============2744484522412582348== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Now that the back end allows passt/pasta to use different external interfaces for IPv4 and IPv6, use that to do the right thing in the case that the host has IPv4 and IPv6 connectivity via different interfaces. If the user hasn't explicitly chosen an interface, separately search for a suitable external interface for each protocol. As a bonus, this substantially simplifies the external interface probe. It also eliminates a subtle confusing case where in some circumstances we would pick the first interface in interface index order, and sometimes in order of routes returned from netlink. On some network configurations that could cause tests to fail, because the logic in the tests was subtly different (it always used route order). Signed-off-by: David Gibson --- conf.c | 19 +++++++++-- netlink.c | 79 ++++--------------------------------------- netlink.h | 2 +- test/dhcp/passt | 3 +- test/dhcp/pasta | 3 +- test/ndp/passt | 4 +-- test/two_guests/basic | 3 +- 7 files changed, 33 insertions(+), 80 deletions(-) diff --git a/conf.c b/conf.c index 943526d..cc08de3 100644 --- a/conf.c +++ b/conf.c @@ -630,8 +630,23 @@ static void conf_ip(struct ctx *c) v4 =3D v6 =3D IP_VERSION_PROBE; } =20 - if (!c->ifi4 && !c->ifi6) - c->ifi4 =3D c->ifi6 =3D nl_get_ext_if(&v4, &v6); + if (v4 !=3D IP_VERSION_DISABLED) { + if (!c->ifi4) + c->ifi4 =3D nl_get_ext_if(AF_INET); + if (!c->ifi4) { + warn("No external routable interface for IPv4"); + v4 =3D IP_VERSION_DISABLED; + } + } + + if (v6 !=3D IP_VERSION_DISABLED) { + if (!c->ifi6) + c->ifi6 =3D nl_get_ext_if(AF_INET6); + if (!c->ifi6) { + warn("No external routable interface for IPv6"); + v6 =3D IP_VERSION_DISABLED; + } + } =20 if (v4 !=3D IP_VERSION_DISABLED) { if (!c->gw4) diff --git a/netlink.c b/netlink.c index 66a95e4..8ad6a0c 100644 --- a/netlink.c +++ b/netlink.c @@ -126,13 +126,13 @@ static int nl_req(int ns, char *buf, const void *req, s= size_t len) } =20 /** - * nl_get_ext_if() - Get interface index supporting IP versions being probed - * @v4: Probe IPv4 support, set to ENABLED or DISABLED on return - * @v6: Probe IPv4 support, set to ENABLED or DISABLED on return + * nl_get_ext_if() - Get interface index supporting IP version being probed + * @af: Address family (AF_INET or AF_INET6) to look for connectivity + * for. * * Return: interface index, 0 if not found */ -unsigned int nl_get_ext_if(int *v4, int *v6) +unsigned int nl_get_ext_if(sa_family_t af) { struct { struct nlmsghdr nlh; struct rtmsg rtm; } req =3D { .nlh.nlmsg_type =3D RTM_GETROUTE, @@ -143,32 +143,14 @@ unsigned int nl_get_ext_if(int *v4, int *v6) .rtm.rtm_table =3D RT_TABLE_MAIN, .rtm.rtm_scope =3D RT_SCOPE_UNIVERSE, .rtm.rtm_type =3D RTN_UNICAST, + .rtm.rtm_family =3D af, }; - unsigned int i, first_v4 =3D 0, first_v6 =3D 0; - uint8_t has_v4[PAGE_SIZE * 8 / 8] =3D { 0 }; /* See __dev_alloc_name() */ - uint8_t has_v6[PAGE_SIZE * 8 / 8] =3D { 0 }; /* in kernel */ struct nlmsghdr *nh; struct rtattr *rta; struct rtmsg *rtm; char buf[BUFSIZ]; - long *word, tmp; - uint8_t *vmap; ssize_t n; size_t na; - int *v; - - if (*v4 =3D=3D IP_VERSION_PROBE) { - v =3D v4; - req.rtm.rtm_family =3D AF_INET; - vmap =3D has_v4; - } else if (*v6 =3D=3D IP_VERSION_PROBE) { -v6: - v =3D v6; - req.rtm.rtm_family =3D AF_INET6; - vmap =3D has_v6; - } else { - return 0; - } =20 if ((n =3D nl_req(0, buf, &req, sizeof(req))) < 0) return 0; @@ -178,7 +160,7 @@ v6: for ( ; NLMSG_OK(nh, n); nh =3D NLMSG_NEXT(nh, n)) { rtm =3D (struct rtmsg *)NLMSG_DATA(nh); =20 - if (rtm->rtm_dst_len || rtm->rtm_family !=3D req.rtm.rtm_family) + if (rtm->rtm_dst_len || rtm->rtm_family !=3D af) continue; =20 for (rta =3D RTM_RTA(rtm), na =3D RTM_PAYLOAD(nh); RTA_OK(rta, na); @@ -190,57 +172,10 @@ v6: =20 ifi =3D *(unsigned int *)RTA_DATA(rta); =20 - if (*v4 =3D=3D IP_VERSION_DISABLED || - *v6 =3D=3D IP_VERSION_DISABLED) { - *v =3D IP_VERSION_ENABLED; - return ifi; - } - - if (v =3D=3D v4 && !first_v4) - first_v4 =3D ifi; - - if (v =3D=3D v6 && !first_v6) - first_v6 =3D ifi; - - bitmap_set(vmap, ifi); + return ifi; } } =20 - if (v =3D=3D v4 && *v6 =3D=3D IP_VERSION_PROBE) { - req.nlh.nlmsg_seq =3D nl_seq++; - goto v6; - } - - word =3D (long *)has_v4; - for (i =3D 0; i < ARRAY_SIZE(has_v4) / sizeof(long); i++, word++) { - tmp =3D *word; - while ((n =3D ffsl(tmp))) { - int ifi =3D i * sizeof(long) * 8 + n - 1; - - if (!first_v4) - first_v4 =3D ifi; - - tmp &=3D ~(1UL << (n - 1)); - if (bitmap_isset(has_v6, ifi)) { - *v4 =3D *v6 =3D IP_VERSION_ENABLED; - return ifi; - } - } - } - - if (first_v4) { - *v4 =3D IP_VERSION_ENABLED; - *v6 =3D IP_VERSION_DISABLED; - return first_v4; - } - - if (first_v6) { - *v4 =3D IP_VERSION_DISABLED; - *v6 =3D IP_VERSION_ENABLED; - return first_v6; - } - - err("No external routable interface for any IP protocol"); return 0; } =20 diff --git a/netlink.h b/netlink.h index 261904e..5ce5037 100644 --- a/netlink.h +++ b/netlink.h @@ -7,7 +7,7 @@ #define NETLINK_H =20 int nl_sock_init(const struct ctx *c); -unsigned int nl_get_ext_if(int *v4, int *v6); +unsigned int nl_get_ext_if(sa_family_t af); void nl_route(int ns, unsigned int ifi, sa_family_t af, void *gw); void nl_addr(int ns, unsigned int ifi, sa_family_t af, void *addr, int *prefix_len, void *addr_l); diff --git a/test/dhcp/passt b/test/dhcp/passt index f45227a..11e0eb3 100644 --- a/test/dhcp/passt +++ b/test/dhcp/passt @@ -17,6 +17,7 @@ htools ip jq sed tr head test Interface name gout IFNAME ip -j link show | jq -rM '.[] | select(.link_type =3D=3D "ether"= ).ifname' hout HOST_IFNAME ip -j -4 route show|jq -rM '[.[] | select(.dst =3D=3D "defa= ult").dev] | .[0]' +hout HOST_IFNAME6 ip -j -6 route show|jq -rM '[.[] | select(.dst =3D=3D "def= ault").dev] | .[0]' check [ -n "__IFNAME__" ] =20 test DHCP: address @@ -49,7 +50,7 @@ check [ "__SEARCH__" =3D "__HOST_SEARCH__" ] test DHCPv6: address guest /sbin/dhclient -6 __IFNAME__ gout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__IFNAME_= _").addr_info[] | select(.prefixlen =3D=3D 128).local' -hout HOST_ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__HO= ST_IFNAME__").addr_info[] | select(.scope =3D=3D "global").local' +hout HOST_ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__HO= ST_IFNAME6__").addr_info[] | select(.scope =3D=3D "global").local' check [ "__ADDR6__" =3D "__HOST_ADDR6__" ] =20 test DHCPv6: route diff --git a/test/dhcp/pasta b/test/dhcp/pasta index 65b1d42..076ec8d 100644 --- a/test/dhcp/pasta +++ b/test/dhcp/pasta @@ -35,8 +35,9 @@ check [ __MTU__ =3D 65520 ] =20 test DHCPv6: address ns /sbin/dhclient -6 --no-pid __IFNAME__ +hout HOST_IFNAME6 ip -j -6 route show|jq -rM '[.[] | select(.dst =3D=3D "def= ault").dev] | .[0]' nsout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__IFNAME= __").addr_info[] | select(.prefixlen =3D=3D 128).local' -hout HOST_ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__IF= NAME__").addr_info[] | select(.scope =3D=3D "global").local' +hout HOST_ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__HO= ST_IFNAME6__").addr_info[] | select(.scope =3D=3D "global").local' check [ __ADDR6__ =3D __HOST_ADDR6__ ] =20 test DHCPv6: route diff --git a/test/ndp/passt b/test/ndp/passt index d6b4c40..8ef15e7 100644 --- a/test/ndp/passt +++ b/test/ndp/passt @@ -17,13 +17,13 @@ htools ip jq sipcalc grep cut test Interface name gout IFNAME ip -j link show | jq -rM '.[] | select(.link_type =3D=3D "ether"= ).ifname' guest ip link set dev __IFNAME__ up && sleep 2 -hout HOST_IFNAME ip -j -4 route show|jq -rM '.[] | select(.dst =3D=3D "defau= lt").dev' +hout HOST_IFNAME6 ip -j -6 route show|jq -rM '.[] | select(.dst =3D=3D "defa= ult").dev' check [ -n "__IFNAME__" ] =20 test SLAAC: prefix gout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__IFNAME_= _").addr_info[] | select(.scope =3D=3D "global" and .prefixlen =3D=3D 64).loc= al' gout PREFIX6 sipcalc __ADDR6__/64 | grep prefix | cut -d' ' -f4 -hout HOST_ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__HO= ST_IFNAME__").addr_info[] | select(.scope =3D=3D "global").local' +hout HOST_ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__HO= ST_IFNAME6__").addr_info[] | select(.scope =3D=3D "global").local' hout HOST_PREFIX6 sipcalc __HOST_ADDR6__/64 | grep prefix | cut -d' ' -f4 check [ "__PREFIX6__" =3D "__HOST_PREFIX6__" ] =20 diff --git a/test/two_guests/basic b/test/two_guests/basic index f7c016d..e226178 100644 --- a/test/two_guests/basic +++ b/test/two_guests/basic @@ -19,6 +19,7 @@ test Interface names g1out IFNAME1 ip -j link show | jq -rM '.[] | select(.link_type =3D=3D "ethe= r").ifname' g2out IFNAME2 ip -j link show | jq -rM '.[] | select(.link_type =3D=3D "ethe= r").ifname' hout HOST_IFNAME ip -j -4 route show|jq -rM '[.[] | select(.dst =3D=3D "defa= ult").dev] | .[0]' +hout HOST_IFNAME6 ip -j -6 route show|jq -rM '[.[] | select(.dst =3D=3D "def= ault").dev] | .[0]' check [ -n "__IFNAME1__" ] check [ -n "__IFNAME2__" ] =20 @@ -40,7 +41,7 @@ guest1 /sbin/dhclient -6 __IFNAME1__ guest2 /sbin/dhclient -6 __IFNAME2__ g1out ADDR1_6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__IFNA= ME1__").addr_info[] | select(.prefixlen =3D=3D 128).local' g2out ADDR2_6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__IFNA= ME2__").addr_info[] | select(.prefixlen =3D=3D 128).local' -hout HOST_ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__HO= ST_IFNAME__").addr_info[] | select(.scope =3D=3D "global").local' +hout HOST_ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__HO= ST_IFNAME6__").addr_info[] | select(.scope =3D=3D "global").local' check [ "__ADDR1_6__" =3D "__HOST_ADDR6__" ] check [ "__ADDR2_6__" =3D "__HOST_ADDR6__" ] =20 --=20 2.37.1 --===============2744484522412582348==--