From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: [PATCH 02/10] test: Split cppcheck and clang-tidy tests into different files
Date: Thu, 18 Aug 2022 16:13:50 +1000 [thread overview]
Message-ID: <20220818061358.1775944-3-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20220818061358.1775944-1-david@gibson.dropbear.id.au>
[-- Attachment #1: Type: text/plain, Size: 2066 bytes --]
Both clang-tidy and cppcheck linting are handled by the same test file,
test/build/static_checkers. The two linters are independent of each other
though, and each one takes quite a long time. Split them into separate
files to make it easier to control which are executed from the top level
test script.
Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
---
test/build/{static_checkers => clang_tidy} | 5 +----
test/build/cppcheck | 17 +++++++++++++++++
test/run | 3 ++-
3 files changed, 20 insertions(+), 5 deletions(-)
rename test/build/{static_checkers => clang_tidy} (86%)
create mode 100644 test/build/cppcheck
diff --git a/test/build/static_checkers b/test/build/clang_tidy
similarity index 86%
rename from test/build/static_checkers
rename to test/build/clang_tidy
index 34c8dff..0ead9e8 100644
--- a/test/build/static_checkers
+++ b/test/build/clang_tidy
@@ -11,10 +11,7 @@
# Copyright (c) 2021 Red Hat GmbH
# Author: Stefano Brivio <sbrivio(a)redhat.com>
-htools clang-tidy cppcheck
+htools clang-tidy
test Run clang-tidy
host make clang-tidy
-
-test Run cppcheck
-host make cppcheck
diff --git a/test/build/cppcheck b/test/build/cppcheck
new file mode 100644
index 0000000..05166dd
--- /dev/null
+++ b/test/build/cppcheck
@@ -0,0 +1,17 @@
+# SPDX-License-Identifier: AGPL-3.0-or-later
+#
+# PASST - Plug A Simple Socket Transport
+# for qemu/UNIX domain socket mode
+#
+# PASTA - Pack A Subtle Tap Abstraction
+# for network namespace/tap device mode
+#
+# test/build/cppcheck - Run source through cppcheck(1) linter
+#
+# Copyright (c) 2021 Red Hat GmbH
+# Author: Stefano Brivio <sbrivio(a)redhat.com>
+
+htools cppcheck
+
+test Run cppcheck
+host make cppcheck
diff --git a/test/run b/test/run
index 3e5d56b..258a89b 100755
--- a/test/run
+++ b/test/run
@@ -61,7 +61,8 @@ run() {
setup build
test build/all
- test build/static_checkers
+ test build/cppcheck
+ test build/clang_tidy
test distro/debian
test distro/fedora
test distro/opensuse
--
@@ -61,7 +61,8 @@ run() {
setup build
test build/all
- test build/static_checkers
+ test build/cppcheck
+ test build/clang_tidy
test distro/debian
test distro/fedora
test distro/opensuse
--
2.37.2
next prev parent reply other threads:[~2022-08-18 6:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 6:13 [PATCH 00/10] passt test fixes, batch 6 David Gibson
2022-08-18 6:13 ` [PATCH 01/10] test: Convert distro tests to use socat instead of nc/ncat David Gibson
2022-08-18 6:13 ` David Gibson [this message]
2022-08-18 6:13 ` [PATCH 03/10] test: Remove unused *_XTERM variables David Gibson
2022-08-18 6:13 ` [PATCH 04/10] test: Ignore video processing temporary files David Gibson
2022-08-18 6:13 ` [PATCH 05/10] test: Split setup/teardown functions for build and distro tests David Gibson
2022-08-18 6:13 ` [PATCH 06/10] test: Only select a single interface or gateway in tests David Gibson
2022-08-18 6:13 ` [PATCH 07/10] test: Rename slightly misleading "valgrind" tests David Gibson
2022-08-18 6:13 ` [PATCH 08/10] test: Use shutdown test for pasta David Gibson
2022-08-18 6:13 ` [PATCH 09/10] test: Log debugging output from test script David Gibson
2022-08-18 6:13 ` [PATCH 10/10] test: Kill qemu by pidfile rather than ^C David Gibson
2022-08-21 20:23 ` [PATCH 00/10] passt test fixes, batch 6 Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818061358.1775944-3-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).