On Tue, 23 Aug 2022 16:31:51 +1000 David Gibson wrote: > There are several places in the passt code where we have lint overrides > because we're not adding CLOEXEC flags to open or other operations. > Comments suggest this is because it's before we fork() into the background > but we'll need those file descriptors after we're in the background. > > However, as the name suggests CLOEXEC closes on exec(), not on fork(). ...after looking into it and trying to remember: it seems like the only reason why I skipped O_CLOEXEC here was some bogus innate assumption I had about file descriptors being closed on clone() too. Thanks for spotting this. -- Stefano