From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject:
 Re: [PATCH 7/8] Use explicit --netns option rather than multiplexing with PID
Date: Mon, 29 Aug 2022 21:16:50 +0200
Message-ID: <20220829211650.1a89a7d4@elisabeth>
In-Reply-To: <20220826045839.1112152-8-david@gibson.dropbear.id.au>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6870226343539218026=="

--===============6870226343539218026==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 26 Aug 2022 14:58:38 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> [...]
>
> +++ b/passt.1
> @@ -15,7 +15,10 @@
>  [\fIOPTION\fR]...
>  .br
>  .B pasta
> -[\fIOPTION\fR]... [\fIPID\fR|\fIPATH\fR|\fINAME\fR]
> +[\fIOPTION\fR]... [\fIPID\fR]
> +.br
> +.B pasta
> +[\fIOPTION\fR]... \fB--netns\fR [\fIPATH\fR|\fINAME\fR]
> =20
>  .SH DESCRIPTION
> =20
> @@ -59,7 +62,7 @@ or with the \fBqrap\fR(1) wrapper.
>  equivalent functionality to network namespaces, as the one offered by
>  \fBpasst\fR for virtual machines.
> =20
> -If PID, PATH or NAME are given, \fBpasta\fR associates to an existing user=
 and
> +If PID or --netns are given, \fBpasta\fR associates to an existing user and
>  network namespace. Otherwise, \fBpasta\fR creates a new user and network
>  namespace, and spawns an interactive shell within this context. A \fItap\fR
>  device within the network namespace is created to provide network connecti=
vity.
> @@ -445,7 +448,14 @@ Default is \fBauto\fR.
>  Target user namespace to join, as a path. If PID is given, without this op=
tion,
>  the user namespace will be the one of the corresponding process.
> =20
> -This option requires PID, PATH or NAME to be specified.
> +This option requires --netns or a PID to be specified.
> +
> +.TP
> +.BR \-\-netns " " \fIspec
> +Target network namespace to join, as a path or a name.  A name is treated =
as
> +with \fBip-netns(8)\fR as a equivalent to a path in \fI/run/netns\fR.

an equivalent (I can fix this up on merge).

--=20
Stefano


--===============6870226343539218026==--