From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 7/7] fedora: Pass explicit bindir, mandir, docdir, and
 drop OpenSUSE override
Date: Mon, 29 Aug 2022 21:23:31 +0200
Message-ID: <20220829212331.5d312ebf@elisabeth>
In-Reply-To: <20220829151709.2650896-8-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4005660598670979968=="

--===============4005660598670979968==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 29 Aug 2022 17:17:09 +0200
Stefano Brivio <sbrivio(a)redhat.com> wrote:

> Fedora's parameters currently match the ones from the Makefile (which
> is based on GNU recommendations), but that's not necessarily
> guaranteed.
>=20
> This should make the OpenSUSE Tumbleweed override for docdir
> unnecessary: drop it.
>=20
> Suggested-by: Daniel P. Berrang=C3=A9 <berrange(a)redhat.com>
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
> ---
>  contrib/fedora/passt.spec | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
> index a8af326..ca22d38 100644
> --- a/contrib/fedora/passt.spec
> +++ b/contrib/fedora/passt.spec
> @@ -49,10 +49,8 @@ This package adds SELinux enforcement to passt(1) and pa=
sta(1).
>  %make_build
> =20
>  %install
> -%if 0%{?suse_version} > 910
> -%make_install DESTDIR=3D%{buildroot} prefix=3D%{_prefix} docdir=3D%{_prefi=
x}/share/doc/packages/passt
> -%else
> -%make_install DESTDIR=3D%{buildroot} prefix=3D%{_prefix}
> +%make_install DESTDIR=3D%{buildroot} prefix=3D%{_prefix} bindir=3D%{_bindi=
r} mandir=3D%{_mandir} docdir=3D%{_docdir}/passt
> +
>  %endif

Oops, I forgot to complete a rebase before sending this: this %endif
goes away of course.

--=20
Stefano


--===============4005660598670979968==--