From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 7/8] Use explicit --netns option rather than multiplexing with PID
Date: Tue, 30 Aug 2022 10:25:59 +0200 [thread overview]
Message-ID: <20220830102559.568126a4@elisabeth> (raw)
In-Reply-To: <Yw1kElWXsuowYwfH@yekko>
[-- Attachment #1: Type: text/plain, Size: 2038 bytes --]
On Tue, 30 Aug 2022 11:12:50 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:
> On Mon, Aug 29, 2022 at 09:16:50PM +0200, Stefano Brivio wrote:
> > On Fri, 26 Aug 2022 14:58:38 +1000
> > David Gibson <david(a)gibson.dropbear.id.au> wrote:
> >
> > > [...]
> > >
> > > +++ b/passt.1
> > > @@ -15,7 +15,10 @@
> > > [\fIOPTION\fR]...
> > > .br
> > > .B pasta
> > > -[\fIOPTION\fR]... [\fIPID\fR|\fIPATH\fR|\fINAME\fR]
> > > +[\fIOPTION\fR]... [\fIPID\fR]
> > > +.br
> > > +.B pasta
> > > +[\fIOPTION\fR]... \fB--netns\fR [\fIPATH\fR|\fINAME\fR]
> > >
> > > .SH DESCRIPTION
> > >
> > > @@ -59,7 +62,7 @@ or with the \fBqrap\fR(1) wrapper.
> > > equivalent functionality to network namespaces, as the one offered by
> > > \fBpasst\fR for virtual machines.
> > >
> > > -If PID, PATH or NAME are given, \fBpasta\fR associates to an existing user and
> > > +If PID or --netns are given, \fBpasta\fR associates to an existing user and
> > > network namespace. Otherwise, \fBpasta\fR creates a new user and network
> > > namespace, and spawns an interactive shell within this context. A \fItap\fR
> > > device within the network namespace is created to provide network connectivity.
> > > @@ -445,7 +448,14 @@ Default is \fBauto\fR.
> > > Target user namespace to join, as a path. If PID is given, without this option,
> > > the user namespace will be the one of the corresponding process.
> > >
> > > -This option requires PID, PATH or NAME to be specified.
> > > +This option requires --netns or a PID to be specified.
> > > +
> > > +.TP
> > > +.BR \-\-netns " " \fIspec
> > > +Target network namespace to join, as a path or a name. A name is treated as
> > > +with \fBip-netns(8)\fR as a equivalent to a path in \fI/run/netns\fR.
> >
> > an equivalent (I can fix this up on merge).
>
> Oops, sorry. I think I meant to say just "as equivalent", which I
> think reads better than "as an equivalent".
Oh, right, then I'll change it to that.
--
Stefano
next prev parent reply other threads:[~2022-08-30 8:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 4:58 [PATCH 0/8] Allow pasta to take a command to spawn instead of shell David Gibson
2022-08-26 4:58 ` [PATCH 1/8] conf: Make the argument to --pcap option mandatory David Gibson
2022-08-26 4:58 ` [PATCH 2/8] conf: Use "-D none" and "-S none" instead of missing empty option arguments David Gibson
2022-08-30 17:41 ` Stefano Brivio
2022-08-26 4:58 ` [PATCH 3/8] Correct manpage for --userns David Gibson
2022-08-26 4:58 ` [PATCH 4/8] Remove --nsrun-dir option David Gibson
2022-08-26 4:58 ` [PATCH 5/8] Move ENOENT error message into conf_ns_opt() David Gibson
2022-08-26 4:58 ` [PATCH 6/8] More deterministic detection of whether argument is a PID, PATH or NAME David Gibson
2022-08-26 4:58 ` [PATCH 7/8] Use explicit --netns option rather than multiplexing with PID David Gibson
2022-08-29 19:16 ` Stefano Brivio
2022-08-30 1:12 ` David Gibson
2022-08-30 8:25 ` Stefano Brivio [this message]
2022-08-26 4:58 ` [PATCH 8/8] Allow pasta to take a command to execute David Gibson
2022-08-29 19:16 ` Stefano Brivio
2022-08-30 1:16 ` David Gibson
2022-08-30 8:26 ` Stefano Brivio
2022-08-30 17:41 ` Stefano Brivio
2022-09-01 10:07 ` [PATCH 0/8] Allow pasta to take a command to spawn instead of shell Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830102559.568126a4@elisabeth \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).