From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: [PATCH v2 1/2] fedora: Add %dir entries for own SELinux policy directory and documentation
Date: Fri, 02 Sep 2022 18:10:39 +0200 [thread overview]
Message-ID: <20220902161040.2758587-2-sbrivio@redhat.com> (raw)
In-Reply-To: <20220902161040.2758587-1-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1807 bytes --]
fedora-review says:
Note: No known owner of /usr/share/selinux/packages/passt,
/usr/share/doc/passt
While at it, replace "passt" by "%{name}" in a few places for
consistency.
Reported-by: Daniel P. Berrangé <berrange(a)redhat.com>
Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
---
v2: Move SELinux entry to the right section, extend usage of %{name}
further, for consistency (Daniel P. Berrangé)
contrib/fedora/passt.spec | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
index 922f584..ca3e8b3 100644
--- a/contrib/fedora/passt.spec
+++ b/contrib/fedora/passt.spec
@@ -49,7 +49,7 @@ This package adds SELinux enforcement to passt(1) and pasta(1).
%make_build
%install
-%make_install DESTDIR=%{buildroot} prefix=%{_prefix} bindir=%{_bindir} mandir=%{_mandir} docdir=%{_docdir}/passt
+%make_install DESTDIR=%{buildroot} prefix=%{_prefix} bindir=%{_bindir} mandir=%{_mandir} docdir=%{_docdir}/%{name}
%ifarch x86_64
ln -sr %{buildroot}%{_mandir}/man1/passt.1 %{buildroot}%{_mandir}/man1/passt.avx2.1
ln -sr %{buildroot}%{_mandir}/man1/pasta.1 %{buildroot}%{_mandir}/man1/pasta.avx2.1
@@ -71,8 +71,9 @@ semodule -r pasta 2>/dev/null || :
%files
%license LICENSES/{AGPL-3.0-or-later.txt,BSD-3-Clause.txt}
-%doc %{_docdir}/passt/README.md
-%doc %{_docdir}/passt/demo.sh
+%dir %{_docdir}/%{name}
+%doc %{_docdir}/%{name}/README.md
+%doc %{_docdir}/%{name}/demo.sh
%{_bindir}/passt
%{_bindir}/pasta
%{_bindir}/qrap
@@ -87,6 +88,7 @@ semodule -r pasta 2>/dev/null || :
%endif
%files selinux
+%dir %{_datadir}/selinux/packages/%{name}
%{_datadir}/selinux/packages/%{name}/passt.pp
%{_datadir}/selinux/packages/%{name}/pasta.pp
--
@@ -49,7 +49,7 @@ This package adds SELinux enforcement to passt(1) and pasta(1).
%make_build
%install
-%make_install DESTDIR=%{buildroot} prefix=%{_prefix} bindir=%{_bindir} mandir=%{_mandir} docdir=%{_docdir}/passt
+%make_install DESTDIR=%{buildroot} prefix=%{_prefix} bindir=%{_bindir} mandir=%{_mandir} docdir=%{_docdir}/%{name}
%ifarch x86_64
ln -sr %{buildroot}%{_mandir}/man1/passt.1 %{buildroot}%{_mandir}/man1/passt.avx2.1
ln -sr %{buildroot}%{_mandir}/man1/pasta.1 %{buildroot}%{_mandir}/man1/pasta.avx2.1
@@ -71,8 +71,9 @@ semodule -r pasta 2>/dev/null || :
%files
%license LICENSES/{AGPL-3.0-or-later.txt,BSD-3-Clause.txt}
-%doc %{_docdir}/passt/README.md
-%doc %{_docdir}/passt/demo.sh
+%dir %{_docdir}/%{name}
+%doc %{_docdir}/%{name}/README.md
+%doc %{_docdir}/%{name}/demo.sh
%{_bindir}/passt
%{_bindir}/pasta
%{_bindir}/qrap
@@ -87,6 +88,7 @@ semodule -r pasta 2>/dev/null || :
%endif
%files selinux
+%dir %{_datadir}/selinux/packages/%{name}
%{_datadir}/selinux/packages/%{name}/passt.pp
%{_datadir}/selinux/packages/%{name}/pasta.pp
--
2.35.1
next prev parent reply other threads:[~2022-09-02 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 16:10 [PATCH v2 0/2] Two further fixes for Fedora's spec file issues Stefano Brivio
2022-09-02 16:10 ` Stefano Brivio [this message]
2022-09-02 16:10 ` [PATCH v2 2/2] fedora: Add selinux-policy Requires: tag Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902161040.2758587-2-sbrivio@redhat.com \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).