From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 2/2] fedora: Add selinux-policy Requires: tag
Date: Fri, 02 Sep 2022 17:47:34 +0200
Message-ID: <20220902174734.6611efc9@elisabeth>
In-Reply-To: <YxIkq3MXOzEAHC/J@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2257804901751553958=="

--===============2257804901751553958==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Fri, 2 Sep 2022 16:43:39 +0100
Daniel P. Berrangé <berrange(a)redhat.com> wrote:

> On Fri, Sep 02, 2022 at 05:38:42PM +0200, Stefano Brivio wrote:
> > fedora-review says:
> > 
> >   Note: Directories without known owners:
> >   /usr/share/selinux/packages/passt, /usr/share/doc/passt,
> >   /usr/share/selinux, /usr/share/selinux/packages
> > 
> > and selinux-policy owns those two last ones.
> > 
> > Reported-by: Daniel P. Berrangé <berrange(a)redhat.com>
> > Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
> > ---
> >  contrib/fedora/passt.spec | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
> > index 1e328e2..f9fd0ab 100644
> > --- a/contrib/fedora/passt.spec
> > +++ b/contrib/fedora/passt.spec
> > @@ -34,7 +34,7 @@ requiring any capabilities or privileges.
> >  %package    selinux
> >  BuildArch:  noarch
> >  Summary:    SELinux support for passt and pasta
> > -Requires:   %{name} = %{version}-%{release}
> > +Requires:   selinux-policy, %{name} = %{version}-%{release}  
> 
> It isn't a requirement, but my preference would be separate Requires
> line for each dep, as it makes the spec more readable.
> 
> >  Requires(post): policycoreutils, %{name}
> >  Requires(preun): policycoreutils, %{name}  

...for consistency, should I then change these two (post, preun) as
well? It starts looking a bit "long" though. Or are those special
somehow?

-- 
Stefano


--===============2257804901751553958==--