From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 1/2] fedora: Add %dir entries for own SELinux policy
 directory and documentation
Date: Fri, 02 Sep 2022 17:58:40 +0200
Message-ID: <20220902175840.69d323a5@elisabeth>
In-Reply-To: <YxIkcTUqJ3YAZBQ5@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1046033643757247228=="

--===============1046033643757247228==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2 Sep 2022 16:42:41 +0100
Daniel P. Berrang=C3=A9 <berrange(a)redhat.com> wrote:

> On Fri, Sep 02, 2022 at 05:38:41PM +0200, Stefano Brivio wrote:
> > fedora-review says:
> >=20
> >   Note: No known owner of /usr/share/selinux/packages/passt,
> >   /usr/share/doc/passt
> >=20
> > Reported-by: Daniel P. Berrang=C3=A9 <berrange(a)redhat.com>
> > Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
> > ---
> >  contrib/fedora/passt.spec | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
> > index 922f584..1e328e2 100644
> > --- a/contrib/fedora/passt.spec
> > +++ b/contrib/fedora/passt.spec
> > @@ -49,7 +49,7 @@ This package adds SELinux enforcement to passt(1) and p=
asta(1).
> >  %make_build
> > =20
> >  %install
> > -%make_install DESTDIR=3D%{buildroot} prefix=3D%{_prefix} bindir=3D%{_bin=
dir} mandir=3D%{_mandir} docdir=3D%{_docdir}/passt
> > +%make_install DESTDIR=3D%{buildroot} prefix=3D%{_prefix} bindir=3D%{_bin=
dir} mandir=3D%{_mandir} docdir=3D%{_docdir}/%{name}
> >  %ifarch x86_64
> >  ln -sr %{buildroot}%{_mandir}/man1/passt.1 %{buildroot}%{_mandir}/man1/p=
asst.avx2.1
> >  ln -sr %{buildroot}%{_mandir}/man1/pasta.1 %{buildroot}%{_mandir}/man1/p=
asta.avx2.1
> > @@ -70,6 +70,8 @@ semodule -r passt 2>/dev/null || :
> >  semodule -r pasta 2>/dev/null || :
> > =20
> >  %files
> > +%dir %{_datadir}/selinux/packages/%{name} =20
>=20
> This needs to be in the -selinux package %files list

Oops, indeed.

> > +%dir %{_docdir}/%{name} =20
>=20
> If you're going to use %{name} here...
>=20
> >  %license LICENSES/{AGPL-3.0-or-later.txt,BSD-3-Clause.txt} =20
>=20
> I'd suggest keeping this as the first item in %files

Moved it back.

> >  %doc %{_docdir}/passt/README.md
> >  %doc %{_docdir}/passt/demo.sh =20
>=20
> ..then be consistent here too

Right, I missed those.

--=20
Stefano


--===============1046033643757247228==--