From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH v2 3/4] test: Parameterize run time for throughput
 performance tests
Date: Tue, 06 Sep 2022 18:22:42 +0200
Message-ID: <20220906182242.603a5080@elisabeth>
In-Reply-To: <20220902020434.24238-4-david@gibson.dropbear.id.au>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8566809705079774841=="

--===============8566809705079774841==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Fri,  2 Sep 2022 12:04:33 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> Currently all the throughput tests are run for 30s.  This is reflected in
> both the actual parameters given to the iperf commands, but also in the
> matching sleeps in test_iperf3.
> 
> Allow this to be adjusted more easily with a new parameter to test_iperf3.
> 
> Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> ---
>  test/lib/test       |  9 +++++----
>  test/perf/passt_tcp | 44 +++++++++++++++++++++++---------------------
>  test/perf/passt_udp | 43 ++++++++++++++++++++++---------------------
>  test/perf/pasta_tcp | 42 ++++++++++++++++++++++--------------------
>  test/perf/pasta_udp | 43 ++++++++++++++++++++++---------------------
>  5 files changed, 94 insertions(+), 87 deletions(-)
> 
> diff --git a/test/lib/test b/test/lib/test
> index 600399b..8eb1ee5 100755
> --- a/test/lib/test
> +++ b/test/lib/test
> @@ -28,6 +28,7 @@ test_iperf3() {
>  	__dest="${1}"; shift
>  	__port="${1}"; shift
>  	__procs="$((${1} - 1))"; shift
> +	__time="${1}"; shift

I'm adding, on merge, this line:

# $7:	Run time, in seconds

to the comment above.

-- 
Stefano


--===============8566809705079774841==--