public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: [PATCH v3 02/12] test: Remove unused variable FFMPEG_PID_FILE
Date: Thu, 08 Sep 2022 16:57:18 +1000	[thread overview]
Message-ID: <20220908065728.2631730-3-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20220908065728.2631730-1-david@gibson.dropbear.id.au>

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

FFPMPEG_PID_FILE is set (creating a temporary file), then never used.

Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
---
 test/lib/video | 1 -
 1 file changed, 1 deletion(-)

diff --git a/test/lib/video b/test/lib/video
index 22e73bb..f609abf 100755
--- a/test/lib/video
+++ b/test/lib/video
@@ -13,7 +13,6 @@
 # Copyright (c) 2021-2022 Red Hat GmbH
 # Author: Stefano Brivio <sbrivio(a)redhat.com>
 
-FFMPEG_PID_FILE="$(mktemp)"
 VIDEO_START_SECONDS=
 VIDEO_NAME=
 
-- 
@@ -13,7 +13,6 @@
 # Copyright (c) 2021-2022 Red Hat GmbH
 # Author: Stefano Brivio <sbrivio(a)redhat.com>
 
-FFMPEG_PID_FILE="$(mktemp)"
 VIDEO_START_SECONDS=
 VIDEO_NAME=
 
-- 
2.37.3


  parent reply	other threads:[~2022-09-08  6:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08  6:57 [PATCH v3 00/12] Improve handling of test temporary files David Gibson
2022-09-08  6:57 ` [PATCH v3 01/12] test: Group tests by context then protocol, rather than the reverse David Gibson
2022-09-08  6:57 ` David Gibson [this message]
2022-09-08  6:57 ` [PATCH v3 03/12] test: Actually run cleanup function David Gibson
2022-09-08  6:57 ` [PATCH v3 04/12] test: Create common state directories for temporary files David Gibson
2022-09-08  6:57 ` [PATCH v3 05/12] test: Move passt_test_log_pipe to state directory David Gibson
2022-09-08  6:57 ` [PATCH v3 06/12] test: Move context temporary files to state dir David Gibson
2022-09-08  6:57 ` [PATCH v3 07/12] test: Dont regnerate small test file in pasta/tcp David Gibson
2022-09-08  6:57 ` [PATCH v3 08/12] test: Use paths in __STATEDIR__ instead of 'temp' and 'tempdir' directives David Gibson
2022-09-08  6:57 ` [PATCH v3 09/12] test: Move pause temporary file to state directory David Gibson
2022-09-08  6:57 ` [PATCH v3 10/12] test: Store pcap files in $LOGDIR instead of /tmp David Gibson
2022-09-08  6:57 ` [PATCH v3 11/12] test: Move pidfiles and nsholder sockets into state directory David Gibson
2022-09-08  6:57 ` [PATCH v3 12/12] test: Move video processing files to $STATEBASE David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220908065728.2631730-3-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).