[PATCH v4 00/12] Improve handling of test temporary files

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 3873 bytes --]

Sigh.  Even more silly errors

The tests create temporary files and fifos in a number of places.
Some of them can interfere with later test runs, and are awkward to
clean up.  Consolidate them in a single per-run directory in /tmp
which gets cleaned up automatically.

This is based on the earlier userns cleanup series.

Changes since v3:
 * Fixed problem with ssh hosts file naming which caused a bunch of
   non-fatal warnings
Changes since v2:
 * Reinstated patch to move the log pipe accidentally dropped during
   a rebase
Chances since v1:
 * Fixed a number of straightforward bugs where things were missed
 * Also removed files we're no longer putting into the source tree
   from .gitignore
 * Added an extra patch moving the video processing files

David Gibson (12):
  test: Group tests by context then protocol, rather than the reverse
  test: Remove unused variable FFMPEG_PID_FILE
  test: Actually run cleanup function
  test: Create common state directories for temporary files
  test: Move passt_test_log_pipe to state directory
  test: Move context temporary files to state dir
  test: Dont regnerate small test file in pasta/tcp
  test: Use paths in __STATEDIR__ instead of 'temp' and 'tempdir'
    directives
  test: Move pause temporary file to state directory
  test: Store pcap files in $LOGDIR instead of /tmp
  test: Move pidfiles and nsholder sockets into state directory
  test: Move video processing files to $STATEBASE

 .gitignore                                    |  1 -
 test/.gitignore                               |  3 -
 test/build/all                                | 31 ++++---
 test/demo/passt                               |  9 +-
 test/demo/pasta                               | 12 ++-
 test/demo/podman                              | 11 ++-
 test/distro/debian                            |  2 +-
 test/distro/fedora                            |  2 +-
 test/distro/opensuse                          | 16 ++--
 test/distro/ubuntu                            |  8 +-
 test/lib/context                              | 61 +++++++-------
 test/lib/layout                               | 16 ++--
 test/lib/setup                                | 84 ++++++++++---------
 test/lib/term                                 | 26 +++---
 test/lib/test                                 | 14 +---
 test/lib/video                                | 20 ++---
 test/{dhcp/passt => passt/dhcp}               |  2 +-
 test/{ndp/passt => passt/ndp}                 |  2 +-
 test/{shutdown/passt => passt/shutdown}       |  4 +-
 test/{tcp/passt => passt/tcp}                 |  6 +-
 test/{udp/passt => passt/udp}                 |  8 +-
 test/{icmp/passt_in_ns => passt_in_ns/icmp}   |  2 +-
 .../passt_in_ns => passt_in_ns/shutdown}      |  4 +-
 test/{tcp/passt_in_ns => passt_in_ns/tcp}     | 10 +--
 test/{udp/passt_in_ns => passt_in_ns/udp}     |  8 +-
 test/{dhcp/pasta => pasta/dhcp}               |  2 +-
 test/{ndp/pasta => pasta/ndp}                 |  2 +-
 test/{tcp/pasta => pasta/tcp}                 | 13 ++-
 test/{udp/pasta => pasta/udp}                 | 20 ++---
 test/run                                      | 48 +++++------
 30 files changed, 217 insertions(+), 230 deletions(-)
 rename test/{dhcp/passt => passt/dhcp} (98%)
 rename test/{ndp/passt => passt/ndp} (95%)
 rename test/{shutdown/passt => passt/shutdown} (80%)
 rename test/{tcp/passt => passt/tcp} (96%)
 rename test/{udp/passt => passt/udp} (88%)
 rename test/{icmp/passt_in_ns => passt_in_ns/icmp} (94%)
 rename test/{shutdown/passt_in_ns => passt_in_ns/shutdown} (79%)
 rename test/{tcp/passt_in_ns => passt_in_ns/tcp} (97%)
 rename test/{udp/passt_in_ns => passt_in_ns/udp} (97%)
 rename test/{dhcp/pasta => pasta/dhcp} (96%)
 rename test/{ndp/pasta => pasta/ndp} (95%)
 rename test/{tcp/pasta => pasta/tcp} (95%)
 rename test/{udp/pasta => pasta/udp} (74%)

-- 
2.37.3