From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: [PATCH v4 12/12] test: Move video processing files to $STATEBASE Date: Fri, 09 Sep 2022 13:30:28 +1000 Message-ID: <20220909033028.570161-13-david@gibson.dropbear.id.au> In-Reply-To: <20220909033028.570161-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6604351652232435814==" --===============6604351652232435814== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The asciinema video handling creates a number of temporary files (.uncat, .start, .stop) which currently go into the source tree. Put them in the temporary state directory to avoid clutter. Put the final processed video into the test_logs/ directory, since it's essentially a test output artefact. Signed-off-by: David Gibson --- test/.gitignore | 3 --- test/lib/term | 8 ++++---- test/lib/video | 19 ++++++++++--------- 3 files changed, 14 insertions(+), 16 deletions(-) diff --git a/test/.gitignore b/test/.gitignore index 0f91c7d..58c8cf2 100644 --- a/test/.gitignore +++ b/test/.gitignore @@ -6,9 +6,6 @@ QEMU_EFI.fd *.qcow2 *.raw *.raw.xz -*.uncut -*.start -*.stop *.js nsholder guest-key diff --git a/test/lib/term b/test/lib/term index d6869c7..5a391e6 100755 --- a/test/lib/term +++ b/test/lib/term @@ -643,12 +643,12 @@ run_term() { =20 if [ ${CI} -eq 1 ]; then printf '\e[8;50;240t' - asciinema rec --overwrite ci.uncut -c "$TMUX /bin/sh -c './ci from_term'" - video_postprocess ci.uncut + asciinema rec --overwrite "${STATEBASE}/ci.uncut" -c "$TMUX /bin/sh -c './= ci from_term'" + video_postprocess "${STATEBASE}/ci.uncut" elif [ ${DEMO} -eq 1 ]; then printf '\e[8;40;130t' - asciinema rec --overwrite demo.uncut -c "$TMUX /bin/sh -c './run_demo from= _term'" - video_postprocess demo.uncut + asciinema rec --overwrite "${STATEBASE}/demo.uncut" -c "$TMUX /bin/sh -c '= ./run_demo from_term'" + video_postprocess "${STATEBASE}/demo.uncut" else $TMUX /bin/sh -c './run from_term' fi diff --git a/test/lib/video b/test/lib/video index f609abf..915a42f 100755 --- a/test/lib/video +++ b/test/lib/video @@ -77,8 +77,8 @@ video_start() { VIDEO_START_SECONDS=3D$(sed -n 's/\([0-9]*\).[0-9]* [0-9]*.[0-9]*/\1/p' /pr= oc/uptime) =20 sync - [ ${DEMO} -eq 1 ] && tail -1 "${BASEPATH}/demo.uncut" > "${BASEPATH}/${VIDE= O_NAME}.start" - [ ${CI} -eq 1 ] && tail -1 "${BASEPATH}/ci.uncut" > "${BASEPATH}/${VIDEO_NA= ME}.start" + [ ${DEMO} -eq 1 ] && tail -1 "${STATEBASE}/demo.uncut" > "${STATEBASE}/${VI= DEO_NAME}.start" + [ ${CI} -eq 1 ] && tail -1 "${STATEBASE}/ci.uncut" > "${STATEBASE}/${VIDEO_= NAME}.start" sync =20 tmux refresh-client @@ -89,8 +89,8 @@ video_stop() { tmux refresh-client =20 sync - [ ${DEMO} -eq 1 ] && tail -1 "${BASEPATH}/demo.uncut" > "${BASEPATH}/${VIDE= O_NAME}.stop" - [ ${CI} -eq 1 ] && tail -1 "${BASEPATH}/ci.uncut" > "${BASEPATH}/${VIDEO_NA= ME}.stop" + [ ${DEMO} -eq 1 ] && tail -1 "${STATEBASE}/demo.uncut" > "${STATEBASE}/${VI= DEO_NAME}.stop" + [ ${CI} -eq 1 ] && tail -1 "${STATEBASE}/ci.uncut" > "${STATEBASE}/${VIDEO_= NAME}.stop" sync =20 sed -i 's/^.*$/&\\/g' "${BASEPATH}/${VIDEO_NAME}.js" @@ -108,12 +108,13 @@ video_postprocess() { [ -z "${__header}" ] && __header=3D"${__l}" && continue =20 if [ -z "${__cast_name}" ]; then - for __cast_cut in *.start; do + for __cast_cut in "${STATEBASE}/"*.start; do [ "${__l}" !=3D "$(cat "${__cast_cut}")" ] && continue - __cast_name=3D"${__cast_cut%.start}" + __cast_name=3D"$(basename "${__cast_cut}")" + __cast_name=3D"${__cast_name%.start}" __cast_offset=3D - __stop_line=3D"$(cat ${__cast_name}.stop)" - echo "${__header}" > "${__cast_name}.cast" + __stop_line=3D"$(cat "${STATEBASE}/${__cast_name}.stop")" + echo "${__header}" > "${LOGDIR}/${__cast_name}.cast" break done continue @@ -125,7 +126,7 @@ video_postprocess() { __l_rest=3D"${__l#*.}" [ -z "${__cast_offset}" ] && __cast_offset=3D${__l_offset} __l_offset=3D$((__l_offset - __cast_offset)) - printf '[%s.%s\n' "${__l_offset}" "${__l_rest}" >> "${__cast_name}".cast + printf '[%s.%s\n' "${__l_offset}" "${__l_rest}" >> "${LOGDIR}/${__cast_nam= e}".cast done unset IFS } --=20 2.37.3 --===============6604351652232435814==--