From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH v2 05/10] Move self-isolation code into a separate file
Date: Fri, 09 Sep 2022 16:33:58 +0200
Message-ID: <20220909163358.64600147@elisabeth>
In-Reply-To: <20220908035907.1750314-6-david@gibson.dropbear.id.au>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7043284250329270569=="

--===============7043284250329270569==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Thu,  8 Sep 2022 13:59:02 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> [...]
>
> +++ b/isolation.c
>
> [...]
>
> +/**
> + * sandbox() - Unshare IPC, mount, PID, UTS, and user namespaces, "unmount=
" root
> + *
> + * Return: negative error code on failure, zero on success
> + */
> +int sandbox(struct ctx *c)

Same here, I would "document" "c".

--=20
Stefano


--===============7043284250329270569==--