From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH v2 00/10] Clean up handling of userns
Date: Fri, 09 Sep 2022 16:36:21 +0200
Message-ID: <20220909163621.6807f8d5@elisabeth>
In-Reply-To: <20220908035907.1750314-1-david@gibson.dropbear.id.au>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5384665049375161020=="

--===============5384665049375161020==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Thu,  8 Sep 2022 13:58:57 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> Sorry for the resend, but I found a bug that means this will fail to
> build on some distros / versions.
> 
> Our handling of user namespaces is more complex than it needs to be.
> This simplifies the handling by identifying and entering (or creating)
> the correct userns earlier, so that later code doesn't need to deal
> with it any more.
> 
> Along the way we make a number of other cleanups to handling of userns
> and setting our user and group.
> 
> This is based on my earlier test command dispatch and performance test
> cleanup series.
> 
> Changes since v1:
>  * Fixed overenthusiastic pruning of #includes when moving the
>    self-isolation code which broke compile on some distro versions

I haven't tested this yet, but it looks great.

I can fix up those small things I reported directly while merging, if
you agree, and apply.

A suggestion on how to update the man page as a result of 10/10 would
help, though.

-- 
Stefano


--===============5384665049375161020==--