From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH v2 07/11] test: Add nsholder utility
Date: Fri, 09 Sep 2022 17:18:58 +0200
Message-ID: <20220909171858.7010d6b7@elisabeth>
In-Reply-To: <20220908014920.1474597-8-david@gibson.dropbear.id.au>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5095015998318323601=="

--===============5095015998318323601==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Nit:

On Thu,  8 Sep 2022 11:49:16 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> [...]
>
> diff --git a/test/nsholder.c b/test/nsholder.c
> new file mode 100644
> index 0000000..bfe3611
> --- /dev/null
> +++ b/test/nsholder.c
> @@ -0,0 +1,117 @@
> +#define _GNU_SOURCE

It would be nice to have a licence and copyright notice here. From my
perspective it's not necessarily needed (it would default to AGPLv3 and
you as copyright holder), but might cause some trouble to packagers.

-- 
Stefano


--===============5095015998318323601==--