From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH v2 11/11] test: Use new-style command issue for passt_in_ns tests Date: Fri, 09 Sep 2022 17:19:02 +0200 Message-ID: <20220909171902.0d2f3efe@elisabeth> In-Reply-To: <20220908014920.1474597-12-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4919911790808082021==" --===============4919911790808082021== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, 8 Sep 2022 11:49:20 +1000 David Gibson wrote: > Put the pieces together to use the new style context based dispatch for > the passt_in_pasta tests. >=20 > Signed-off-by: David Gibson > > [...] > > +++ b/test/lib/setup > > [...] > > @@ -156,21 +147,18 @@ setup_passt_in_ns() { > [ ${TRACE} -eq 1 ] && __opts=3D"${__opts} --trace" > =20 > if [ ${VALGRIND} -eq 1 ]; then > - pane_run PASST "make clean" > - pane_status PASST > - pane_run PASST "make valgrind" > - pane_status PASST > - pane_run PASST "valgrind --max-stackframe=3D$((4 * 1024 * 1024)) --trace= -children=3Dyes --vgdb=3Dno --error-exitcode=3D1 --suppressions=3Dtest/valgri= nd.supp ./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,10021,= 10031 -P passt.pid" > + context_run passt "make clean" > + context_run passt "make valgrind" > + context_run_bg passt "valgrind --max-stackframe=3D$((4 * 1024 * 1024)) -= -trace-children=3Dyes --vgdb=3Dno --error-exitcode=3D1 --suppressions=3Dtest/= valgrind.supp ./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,= 10021,10031 -P passt.pid" > else > - pane_run PASST "make clean" > - pane_status PASST > - pane_run PASST "make" > - pane_status PASST > - pane_run PASST "./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001= ,10011,10021,10031 -P passt.pid" > + context_run passt "make clean" > + context_run passt "make" > + context_run_bg passt "./passt -f ${__opts} -t 10001,10011,10021,10031 -u= 10001,10011,10021,10031 -P passt.pid" > fi > sleep 5 > =20 > - pane_run GUEST './qrap 5 qemu-system-$(uname -m)' \ > + GUEST_CID=3D94557 While this seems to be perfectly valid: is it supposed to be random, or a specific number for a reason I'm missing...? --=20 Stefano --===============4919911790808082021==--