From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH v2 11/11] test: Use new-style command issue for passt_in_ns tests
Date: Sat, 10 Sep 2022 22:40:49 +0200 [thread overview]
Message-ID: <20220910224049.4ae3ef9b@elisabeth> (raw)
In-Reply-To: <YxwzACF5jF4y8jTF@yekko>
[-- Attachment #1: Type: text/plain, Size: 2491 bytes --]
On Sat, 10 Sep 2022 16:47:28 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:
> On Fri, Sep 09, 2022 at 05:19:02PM +0200, Stefano Brivio wrote:
> > On Thu, 8 Sep 2022 11:49:20 +1000
> > David Gibson <david(a)gibson.dropbear.id.au> wrote:
> >
> > > Put the pieces together to use the new style context based dispatch for
> > > the passt_in_pasta tests.
> > >
> > > Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> > >
> > > [...]
> > >
> > > +++ b/test/lib/setup
> > >
> > > [...]
> > >
> > > @@ -156,21 +147,18 @@ setup_passt_in_ns() {
> > > [ ${TRACE} -eq 1 ] && __opts="${__opts} --trace"
> > >
> > > if [ ${VALGRIND} -eq 1 ]; then
> > > - pane_run PASST "make clean"
> > > - pane_status PASST
> > > - pane_run PASST "make valgrind"
> > > - pane_status PASST
> > > - pane_run PASST "valgrind --max-stackframe=$((4 * 1024 * 1024)) --trace-children=yes --vgdb=no --error-exitcode=1 --suppressions=test/valgrind.supp ./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,10021,10031 -P passt.pid"
> > > + context_run passt "make clean"
> > > + context_run passt "make valgrind"
> > > + context_run_bg passt "valgrind --max-stackframe=$((4 * 1024 * 1024)) --trace-children=yes --vgdb=no --error-exitcode=1 --suppressions=test/valgrind.supp ./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,10021,10031 -P passt.pid"
> > > else
> > > - pane_run PASST "make clean"
> > > - pane_status PASST
> > > - pane_run PASST "make"
> > > - pane_status PASST
> > > - pane_run PASST "./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,10021,10031 -P passt.pid"
> > > + context_run passt "make clean"
> > > + context_run passt "make"
> > > + context_run_bg passt "./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,10021,10031 -P passt.pid"
> > > fi
> > > sleep 5
> > >
> > > - pane_run GUEST './qrap 5 qemu-system-$(uname -m)' \
> > > + GUEST_CID=94557
> >
> > While this seems to be perfectly valid: is it supposed to be random, or
> > a specific number for a reason I'm missing...?
>
> It's entirely arbitrary - I went with as close a visual approximation
> of 'passt' as I could manage with digits (which isn't very close at
> all).
Hah, sorry, of course. I would say it's actually the most acceptable
translation of passt in leetspeek:
https://en.wikipedia.org/wiki/Leet#Orthography
...never mind.
--
Stefano
next prev parent reply other threads:[~2022-09-10 20:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 1:49 [PATCH v2 00/11] Improve command dispatch in test scripts David Gibson
2022-09-08 1:49 ` [PATCH v2 01/11] test: Correctly match "background" with "wait" commands David Gibson
2022-09-08 1:49 ` [PATCH v2 02/11] test: Context execution helpers David Gibson
2022-09-08 1:49 ` [PATCH v2 03/11] test: Allow a tmux pane to watch commands executed in contexts David Gibson
2022-09-09 15:18 ` Stefano Brivio
2022-09-10 6:36 ` David Gibson
2022-09-08 1:49 ` [PATCH v2 04/11] test: Integration of old-style pane execution and new context execution David Gibson
2022-09-08 1:49 ` [PATCH v2 05/11] test: Issue host commands via context for most tests David Gibson
2022-09-09 15:18 ` Stefano Brivio
2022-09-10 6:38 ` David Gibson
2022-09-08 1:49 ` [PATCH v2 06/11] test: Use new-style contexts for passt pane in the pasta and passt tests David Gibson
2022-09-08 1:49 ` [PATCH v2 07/11] test: Add nsholder utility David Gibson
2022-09-09 15:18 ` Stefano Brivio
2022-09-10 6:45 ` David Gibson
2022-09-08 1:49 ` [PATCH v2 08/11] test: Extend context system to run commands in namespace for pasta tests David Gibson
2022-09-08 1:49 ` [PATCH v2 09/11] test: Use context system for guest commands David Gibson
2022-09-08 1:49 ` [PATCH v2 10/11] test: Use context system for two_guests tests David Gibson
2022-09-08 1:49 ` [PATCH v2 11/11] test: Use new-style command issue for passt_in_ns tests David Gibson
2022-09-09 15:19 ` Stefano Brivio
2022-09-10 6:47 ` David Gibson
2022-09-10 20:40 ` Stefano Brivio [this message]
2022-09-09 15:21 ` [PATCH v2 00/11] Improve command dispatch in test scripts Stefano Brivio
2022-09-10 6:59 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220910224049.4ae3ef9b@elisabeth \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).