From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Subject:
 Re: [PATCH v2 11/11] test: Use new-style command issue for passt_in_ns tests
Date: Sat, 10 Sep 2022 22:40:49 +0200
Message-ID: <20220910224049.4ae3ef9b@elisabeth>
In-Reply-To: <YxwzACF5jF4y8jTF@yekko>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4219604901655220872=="

--===============4219604901655220872==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 10 Sep 2022 16:47:28 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

> On Fri, Sep 09, 2022 at 05:19:02PM +0200, Stefano Brivio wrote:
> > On Thu,  8 Sep 2022 11:49:20 +1000
> > David Gibson <david(a)gibson.dropbear.id.au> wrote:
> >  =20
> > > Put the pieces together to use the new style context based dispatch for
> > > the passt_in_pasta tests.
> > >=20
> > > Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> > >
> > > [...]
> > >
> > > +++ b/test/lib/setup
> > >
> > > [...]
> > >
> > > @@ -156,21 +147,18 @@ setup_passt_in_ns() {
> > >  	[ ${TRACE} -eq 1 ] && __opts=3D"${__opts} --trace"
> > > =20
> > >  	if [ ${VALGRIND} -eq 1 ]; then
> > > -		pane_run PASST "make clean"
> > > -		pane_status PASST
> > > -		pane_run PASST "make valgrind"
> > > -		pane_status PASST
> > > -		pane_run PASST "valgrind --max-stackframe=3D$((4 * 1024 * 1024)) --t=
race-children=3Dyes --vgdb=3Dno --error-exitcode=3D1 --suppressions=3Dtest/va=
lgrind.supp ./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,10=
021,10031 -P passt.pid"
> > > +		context_run passt "make clean"
> > > +		context_run passt "make valgrind"
> > > +		context_run_bg passt "valgrind --max-stackframe=3D$((4 * 1024 * 1024=
)) --trace-children=3Dyes --vgdb=3Dno --error-exitcode=3D1 --suppressions=3Dt=
est/valgrind.supp ./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10=
011,10021,10031 -P passt.pid"
> > >  	else
> > > -		pane_run PASST "make clean"
> > > -		pane_status PASST
> > > -		pane_run PASST "make"
> > > -		pane_status PASST
> > > -		pane_run PASST "./passt -f ${__opts} -t 10001,10011,10021,10031 -u 1=
0001,10011,10021,10031 -P passt.pid"
> > > +		context_run passt "make clean"
> > > +		context_run passt "make"
> > > +		context_run_bg passt "./passt -f ${__opts} -t 10001,10011,10021,1003=
1 -u 10001,10011,10021,10031 -P passt.pid"
> > >  	fi
> > >  	sleep 5
> > > =20
> > > -	pane_run GUEST './qrap 5 qemu-system-$(uname -m)'                  \
> > > +	GUEST_CID=3D94557 =20
> >=20
> > While this seems to be perfectly valid: is it supposed to be random, or
> > a specific number for a reason I'm missing...? =20
>=20
> It's entirely arbitrary - I went with as close a visual approximation
> of 'passt' as I could manage with digits (which isn't very close at
> all).

Hah, sorry, of course. I would say it's actually the most acceptable
translation of passt in leetspeek:
  https://en.wikipedia.org/wiki/Leet#Orthography

...never mind.

--=20
Stefano


--===============4219604901655220872==--